deployment,scripts: remove dead configList config key#14804
Draft
nimrod-starkware wants to merge 1 commit into
Draft
deployment,scripts: remove dead configList config key#14804nimrod-starkware wants to merge 1 commit into
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jul 14, 2026
Open
Draft
Contributor
Author
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
from
July 14, 2026 13:48
855a91c to
06d2f71
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/revert-config-optional
branch
from
July 14, 2026 13:48
894a6cf to
1b368c0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
from
July 14, 2026 13:56
06d2f71 to
defff06
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/revert-config-optional
branch
from
July 14, 2026 14:11
03115ad to
a4b3efa
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
from
July 14, 2026 14:11
defff06 to
5ddb04b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
from
July 14, 2026 14:59
5ddb04b to
6f4ffcb
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/revert-config-optional
branch
from
July 14, 2026 14:59
a4b3efa to
5aa86cf
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
from
July 14, 2026 16:05
6f4ffcb to
900728c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
2 times, most recently
from
July 15, 2026 11:20
8f89c7b to
a5b95e9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/revert-config-optional
branch
from
July 15, 2026 11:20
48c885e to
9ef9b80
Compare
configList was a vestige of the retired preset config path (removed along with loaders.py/NodeConfigLoader and the --config_format flag). Its path value has been dead since native became the sole config loader; only the key's presence still gated the ConfigMap volume/mount and the --config_file arg. The ConfigMap is now built unconditionally for every service (from node.jsonnet) and every service carries a config block, so those gates key off config presence instead. Removes the schema field, the configmap guard, the three pod_builder gates, the merger special-casing, the configList line from all layout/overlay service YAMLs, the dead get_config_list() in liveness_check.py, and the orphaned replacer_deployment_common.json / replacer_common.json test fixtures. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/revert-config-optional
branch
from
July 15, 2026 11:26
9ef9b80 to
d2cc41f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-configlist
branch
from
July 15, 2026 11:26
a5b95e9 to
441c415
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

configList was a vestige of the retired preset config path (removed along with
loaders.py/NodeConfigLoader and the --config_format flag). Its path value has
been dead since native became the sole config loader; only the key's presence
still gated the ConfigMap volume/mount and the --config_file arg. The ConfigMap
is now built unconditionally for every service (from node.jsonnet) and every
service carries a config block, so those gates key off config presence instead.
Removes the schema field, the configmap guard, the three pod_builder gates, the
merger special-casing, the configList line from all layout/overlay service
YAMLs, the dead get_config_list() in liveness_check.py, and the orphaned
replacer_deployment_common.json / replacer_common.json test fixtures.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com