Skip to content

deployment,scripts: remove dead configList config key#14804

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/revert-config-optionalfrom
nimrod/jsonnet/remove-configlist
Draft

deployment,scripts: remove dead configList config key#14804
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/revert-config-optionalfrom
nimrod/jsonnet/remove-configlist

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

configList was a vestige of the retired preset config path (removed along with
loaders.py/NodeConfigLoader and the --config_format flag). Its path value has
been dead since native became the sole config loader; only the key's presence
still gated the ConfigMap volume/mount and the --config_file arg. The ConfigMap
is now built unconditionally for every service (from node.jsonnet) and every
service carries a config block, so those gates key off config presence instead.

Removes the schema field, the configmap guard, the three pod_builder gates, the
merger special-casing, the configList line from all layout/overlay service
YAMLs, the dead get_config_list() in liveness_check.py, and the orphaned
replacer_deployment_common.json / replacer_common.json test fixtures.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

This was referenced Jul 14, 2026

nimrod-starkware commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch from 855a91c to 06d2f71 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/revert-config-optional branch from 894a6cf to 1b368c0 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch from 06d2f71 to defff06 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/revert-config-optional branch from 03115ad to a4b3efa Compare July 14, 2026 14:11
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch from defff06 to 5ddb04b Compare July 14, 2026 14:11
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch from 5ddb04b to 6f4ffcb Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/revert-config-optional branch from a4b3efa to 5aa86cf Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch from 6f4ffcb to 900728c Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch 2 times, most recently from 8f89c7b to a5b95e9 Compare July 15, 2026 11:20
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/revert-config-optional branch from 48c885e to 9ef9b80 Compare July 15, 2026 11:20
configList was a vestige of the retired preset config path (removed along with
loaders.py/NodeConfigLoader and the --config_format flag). Its path value has
been dead since native became the sole config loader; only the key's presence
still gated the ConfigMap volume/mount and the --config_file arg. The ConfigMap
is now built unconditionally for every service (from node.jsonnet) and every
service carries a config block, so those gates key off config presence instead.

Removes the schema field, the configmap guard, the three pod_builder gates, the
merger special-casing, the configList line from all layout/overlay service
YAMLs, the dead get_config_list() in liveness_check.py, and the orphaned
replacer_deployment_common.json / replacer_common.json test fixtures.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/revert-config-optional branch from 9ef9b80 to d2cc41f Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-configlist branch from a5b95e9 to 441c415 Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants