Skip to content

deployment: add dummy_for_testing native config override layer#14632

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-sole-loadfrom
nimrod/jsonnet/dummy-for-testing-native-layer
Open

deployment: add dummy_for_testing native config override layer#14632
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/native-sole-loadfrom
nimrod/jsonnet/dummy-for-testing-native-layer

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

The prepare-production-overlays CI job synths each prod overlay env-only
(-o hybrid. -o hybrid.common.dummy_for_testing), with no per-node leaf or
devops checkout. Under the native config path this errored on a missing
overrides.validator_id (and the consensus/mempool multiaddrs) because the
dummy_for_testing overlay had YAML but no native sequencer_config.jsonnet. Add
that layer (the folded nested translation of dummy_for_testing's YAMLs:
validator_id plus the #is_none multiaddrs as null) so env-only native synth
succeeds for mainnet, sepolia-alpha and sepolia-integration. Add the matching
*_layer_jsonnet_mirrors_combined_yaml regression test.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

nimrod-starkware commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 3765446 to 8a5e826 Compare June 28, 2026 08:19
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 06da659 to 5eb5701 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 8a5e826 to 082340c Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 5eb5701 to ec5b1f7 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 082340c to 8852b34 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from ec5b1f7 to ff18571 Compare June 28, 2026 14:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 89452a4. Configure here.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from ec55ded to dc66051 Compare July 9, 2026 12:43
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch 2 times, most recently from 5eb5d04 to f81e54a Compare July 9, 2026 13:27
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 443d831 to ef8a7f6 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch 4 times, most recently from b3a97b1 to c69700d Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch 2 times, most recently from 99eb423 to d9bc8a3 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch 3 times, most recently from f9b228c to e4a3050 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 5a42229 to a242d83 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from e4a3050 to 4639c74 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from a242d83 to 9938ec5 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch 3 times, most recently from de17696 to 2207acc Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 27a4de4 to 0ed8464 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 0ed8464 to a774af9 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 2207acc to 50dcbd4 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 50dcbd4 to e47efc7 Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants