apollo_deployments: retire dead preset/replacer generation machinery#14647
Open
nimrod-starkware wants to merge 1 commit into
Open
Conversation
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
Open
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
June 28, 2026 10:14
89ab258 to
c0351e0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
June 28, 2026 10:14
0df4a4a to
a07b98f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
June 28, 2026 10:30
a07b98f to
a3d7879
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
2 times, most recently
from
June 28, 2026 14:04
4f5f772 to
ece79f9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 12, 2026 08:50
15f18dd to
b5c38a5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 12, 2026 10:04
25152e6 to
e03f18e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 12, 2026 10:04
b5c38a5 to
8afcf69
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 12, 2026 10:51
e03f18e to
74ecb08
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
2 times, most recently
from
July 13, 2026 10:07
40c21a1 to
a21c530
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 13, 2026 11:00
626a03c to
9bcf85d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 13, 2026 11:00
a21c530 to
42d9a4f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 13, 2026 11:47
9bcf85d to
b01aab0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 13, 2026 11:47
42d9a4f to
0c5ceb7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 06:16
b01aab0 to
c682d4d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 14, 2026 06:16
0c5ceb7 to
33a4d9f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 09:16
c682d4d to
816d736
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 14, 2026 09:16
33a4d9f to
3daf971
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3daf971. Configure here.
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 13:48
816d736 to
a53f640
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
2 times, most recently
from
July 14, 2026 13:56
4ecb1a1 to
9f70ed4
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
2 times, most recently
from
July 14, 2026 14:59
8f99f07 to
2e9532b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 14, 2026 14:59
9f70ed4 to
3130853
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 16:05
2e9532b to
a9fa937
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 14, 2026 16:05
3130853 to
92cdc3e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 15, 2026 11:10
a9fa937 to
3003d96
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 15, 2026 11:10
92cdc3e to
0783055
Compare
Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so the preset-replacer GENERATION machinery is dead. Remove it: - Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep). - service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/ prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's exclusion set). - Delete the 3 migration guard tests (deployment_files_are_up_to_date, replacer_config_entries_are_in_config, duplicate_config_entries). Keep the build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards, and get_component_configs. The cdk8s configList field is presence-checked only (its targets live in a different directory and are not read under native), so deleting the base replacer JSONs leaves synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 15, 2026 11:26
3003d96 to
d41c665
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 15, 2026 11:26
0783055 to
7d5ff2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so
the preset-replacer GENERATION machinery is dead. Remove it:
deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep).
prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep
KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's
exclusion set).
replacer_config_entries_are_in_config, duplicate_config_entries). Keep the
build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards,
and get_component_configs.
The cdk8s configList field is presence-checked only (its targets live in a different
directory and are not read under native), so deleting the base replacer JSONs leaves
synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com