Skip to content

apollo_deployments: retire dead preset/replacer generation machinery#14647

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-preset-config-pathfrom
nimrod/jsonnet/retire-replacer-generation
Open

apollo_deployments: retire dead preset/replacer generation machinery#14647
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-preset-config-pathfrom
nimrod/jsonnet/retire-replacer-generation

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so
the preset-replacer GENERATION machinery is dead. Remove it:

  • Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the
    deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep).
  • service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/
    prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep
    KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's
    exclusion set).
  • Delete the 3 migration guard tests (deployment_files_are_up_to_date,
    replacer_config_entries_are_in_config, duplicate_config_entries). Keep the
    build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards,
    and get_component_configs.

The cdk8s configList field is presence-checked only (its targets live in a different
directory and are not read under native), so deleting the base replacer JSONs leaves
synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 89ab258 to c0351e0 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 0df4a4a to a07b98f Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a07b98f to a3d7879 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch 2 times, most recently from 4f5f772 to ece79f9 Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 15f18dd to b5c38a5 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 25152e6 to e03f18e Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from b5c38a5 to 8afcf69 Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from e03f18e to 74ecb08 Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch 2 times, most recently from 40c21a1 to a21c530 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 626a03c to 9bcf85d Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from a21c530 to 42d9a4f Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 9bcf85d to b01aab0 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 42d9a4f to 0c5ceb7 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from b01aab0 to c682d4d Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 0c5ceb7 to 33a4d9f Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from c682d4d to 816d736 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 33a4d9f to 3daf971 Compare July 14, 2026 09:16

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3daf971. Configure here.

Comment thread crates/apollo_deployments/src/deployment_definitions.rs
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 816d736 to a53f640 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch 2 times, most recently from 4ecb1a1 to 9f70ed4 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch 2 times, most recently from 8f99f07 to 2e9532b Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 9f70ed4 to 3130853 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 2e9532b to a9fa937 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 3130853 to 92cdc3e Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a9fa937 to 3003d96 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 92cdc3e to 0783055 Compare July 15, 2026 11:10
Runtime (Phase 1) and the cdk8s deploy (Phase 2) now load only native config, so
the preset-replacer GENERATION machinery is dead. Remove it:
- Delete resources/app_configs/replacer_*.json (19 files), src/replacers.rs, and the
  deployment_generator bin (+ its [[bin]] entry and the tempfile dev-dep).
- service.rs: drop the replacer-annotation plumbing, the deploy-path config_to_preset/
  prune_by_is_none calls, and the orphaned ComponentConfigsSerializationWrapper. Keep
  KEYS_TO_BE_REPLACED (still feeds the retained applicative_matches_app_configs guard's
  exclusion set).
- Delete the 3 migration guard tests (deployment_files_are_up_to_date,
  replacer_config_entries_are_in_config, duplicate_config_entries). Keep the
  build_*_deserializes, applicative_matches_app_configs, and *_infra_matches_rust guards,
  and get_component_configs.

The cdk8s configList field is presence-checked only (its targets live in a different
directory and are not read under native), so deleting the base replacer JSONs leaves
synth green. apollo_deployments: 9 tests pass; cdk8s synth green for all overlays.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 3003d96 to d41c665 Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 0783055 to 7d5ff2c Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants