Skip to content

apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery#14654

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/presentation-off-dumpfrom
nimrod/jsonnet/remove-serialize-config
Draft

apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery#14654
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/presentation-off-dumpfrom
nimrod/jsonnet/remove-serialize-config

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Final teardown of the preset config path. The native loader is the sole
load path, so the dump()/SerializeConfig apparatus has no remaining
consumers.

  • Delete the SerializeConfig trait, dump()/dump_to_file(),
    combine_config_map_and_pointers, the ser_*/prepend_sub_config_name
    builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs
    trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError).
  • Delete all ~107 impl SerializeConfig blocks across ~50 crates.
  • Remove the SerializeConfig supertrait bound from StorageConfigTrait
    (trait kept) and the storage/committer config impls.
  • Delete config_to_preset/prune_by_is_none defs (config_utils.rs) and the
    orphaned inherent NativeClassesWhitelist::ser_param (blockifier).
  • Retire the update_apollo_node_config_schema bin: config_secrets_schema.json
    is now the hand-maintained source of truth (Option A). Replace the
    dump()-derived secrets guard with a type-based guard that serializes
    default() and asserts the Sensitive-redacted paths are a subset of the
    committed schema (documented gap: None-default secrets emit no sentinel).
  • config_secrets_schema.json is byte-unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 778fa43 to 9042cc1 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 854a17f to 2a04c11 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 9042cc1 to 23c8108 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 2a04c11 to 9b20690 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 35763d3 to f32a272 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch 3 times, most recently from d3561ad to 8126e15 Compare July 14, 2026 09:54
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 8a7e8d7 to 34bfe37 Compare July 14, 2026 09:54
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 8126e15 to fa9633f Compare July 14, 2026 10:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch 2 times, most recently from ab93bfe to 55a1ab5 Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from fa9633f to 2a68f9e Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 55a1ab5 to 6971a62 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 2a68f9e to 2d70740 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 6971a62 to 802b673 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch 2 times, most recently from 6742e5b to d6689b7 Compare July 14, 2026 14:11
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 802b673 to a573227 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from d6689b7 to 1cd1eb2 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from a573227 to c9c6e85 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 1cd1eb2 to c3a6a1e Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from c9c6e85 to 9f39d9b Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch 2 times, most recently from 17e9a82 to 9a99b1c Compare July 15, 2026 11:20
… machinery

Final teardown of the preset config path. The native loader is the sole
load path, so the dump()/SerializeConfig apparatus has no remaining
consumers.

- Delete the SerializeConfig trait, dump()/dump_to_file(),
  combine_config_map_and_pointers, the ser_*/prepend_sub_config_name
  builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs
  trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError).
- Delete all ~107 impl SerializeConfig blocks across ~50 crates.
- Remove the SerializeConfig supertrait bound from StorageConfigTrait
  (trait kept) and the storage/committer config impls.
- Delete config_to_preset/prune_by_is_none defs (config_utils.rs) and the
  orphaned inherent NativeClassesWhitelist::ser_param (blockifier).
- Retire the update_apollo_node_config_schema bin: config_secrets_schema.json
  is now the hand-maintained source of truth (Option A). Replace the
  dump()-derived secrets guard with a type-based guard that serializes
  default() and asserts the Sensitive-redacted paths are a subset of the
  committed schema (documented gap: None-default secrets emit no sentinel).
- config_secrets_schema.json is byte-unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 9a99b1c to a8299bb Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 9f39d9b to a1eee5e Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants