apollo_config,workspace: remove SerializeConfig trait and preset-dump machinery#14654
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
|
Artifacts upload workflows: |
This was referenced Jun 28, 2026
Open
Contributor
Author
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
June 28, 2026 10:14
cdced14 to
dbc39e5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
June 28, 2026 10:30
dbc39e5 to
786854f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
2 times, most recently
from
June 28, 2026 14:04
11caafd to
3096831
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
June 28, 2026 14:04
786854f to
318f298
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 13, 2026 10:07
778fa43 to
9042cc1
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 13, 2026 11:00
854a17f to
2a04c11
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 13, 2026 11:00
9042cc1 to
23c8108
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 13, 2026 11:47
2a04c11 to
9b20690
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 06:16
35763d3 to
f32a272
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
3 times, most recently
from
July 14, 2026 09:54
d3561ad to
8126e15
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 09:54
8a7e8d7 to
34bfe37
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 10:47
8126e15 to
fa9633f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
2 times, most recently
from
July 14, 2026 11:32
ab93bfe to
55a1ab5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 11:32
fa9633f to
2a68f9e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 13:48
55a1ab5 to
6971a62
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 13:48
2a68f9e to
2d70740
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 13:56
6971a62 to
802b673
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
2 times, most recently
from
July 14, 2026 14:11
6742e5b to
d6689b7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 14:59
802b673 to
a573227
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 14:59
d6689b7 to
1cd1eb2
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 16:05
a573227 to
c9c6e85
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 16:05
1cd1eb2 to
c3a6a1e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 15, 2026 11:10
c9c6e85 to
9f39d9b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
2 times, most recently
from
July 15, 2026 11:20
17e9a82 to
9a99b1c
Compare
… machinery Final teardown of the preset config path. The native loader is the sole load path, so the dump()/SerializeConfig apparatus has no remaining consumers. - Delete the SerializeConfig trait, dump()/dump_to_file(), combine_config_map_and_pointers, the ser_*/prepend_sub_config_name builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError). - Delete all ~107 impl SerializeConfig blocks across ~50 crates. - Remove the SerializeConfig supertrait bound from StorageConfigTrait (trait kept) and the storage/committer config impls. - Delete config_to_preset/prune_by_is_none defs (config_utils.rs) and the orphaned inherent NativeClassesWhitelist::ser_param (blockifier). - Retire the update_apollo_node_config_schema bin: config_secrets_schema.json is now the hand-maintained source of truth (Option A). Replace the dump()-derived secrets guard with a type-based guard that serializes default() and asserts the Sensitive-redacted paths are a subset of the committed schema (documented gap: None-default secrets emit no sentinel). - config_secrets_schema.json is byte-unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 15, 2026 11:26
9a99b1c to
a8299bb
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 15, 2026 11:26
9f39d9b to
a1eee5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Final teardown of the preset config path. The native loader is the sole
load path, so the dump()/SerializeConfig apparatus has no remaining
consumers.
combine_config_map_and_pointers, the ser_*/prepend_sub_config_name
builders, and IS_NONE_MARK (apollo_config/src/dumping.rs deleted; lib.rs
trimmed, keeping ParamPath/FIELD_SEPARATOR/SerializationType/ConfigError).
(trait kept) and the storage/committer config impls.
orphaned inherent NativeClassesWhitelist::ser_param (blockifier).
is now the hand-maintained source of truth (Option A). Replace the
dump()-derived secrets guard with a type-based guard that serializes
default() and asserts the Sensitive-redacted paths are a subset of the
committed schema (documented gap: None-default secrets emit no sentinel).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com