Skip to content

apollo_config: make native the sole config-load path#14631

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/harness-native-configfrom
nimrod/jsonnet/native-sole-load
Open

apollo_config: make native the sole config-load path#14631
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/harness-native-configfrom
nimrod/jsonnet/native-sole-load

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Delete the preset branch of load_and_process_config so load_native is the only
loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI
override parser (build_args_parser/update_config_map_by_command_args), the
load-time config_schema.json read, the pointer-resolution and #is_none-folding
functions (split_pointers_map, split_values_and_types,
update_config_map_by_pointers, update_optional_values), and the config_parity
dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS,
CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for
later phases.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/config-serde-symmetric branch from 22984a6 to 407157e Compare June 28, 2026 08:19
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from d8e24ea to 06da659 Compare June 28, 2026 08:19
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 06da659 to 5eb5701 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/config-serde-symmetric branch from 407157e to 9b677ae Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 5eb5701 to ec5b1f7 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/config-serde-symmetric branch from 9b677ae to de0822e Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch 2 times, most recently from 443d831 to ef8a7f6 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/config-serde-symmetric branch from 90ee096 to c26fd0b Compare July 12, 2026 08:50

@nimrod-starkware nimrod-starkware left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on dan-starkware and matanl-starkware).


crates/apollo_config/src/loading.rs line 102 at r4 (raw file):

    command: Command,
    args: Vec<String>,
    _ignore_default_values: bool,

remove

Code quote:

_ignore_default_values: bool,

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/config-serde-symmetric branch from c26fd0b to 05266f9 Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from ef8a7f6 to 3f90357 Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/config-serde-symmetric branch from 05266f9 to c9c78dd Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 3f90357 to 3cd9d0b Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware changed the base branch from nimrod/jsonnet/config-serde-symmetric to graphite-base/14631 July 13, 2026 08:40
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 3cd9d0b to 99eb423 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware changed the base branch from graphite-base/14631 to nimrod/jsonnet/harness-native-config July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 99eb423 to d9bc8a3 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/harness-native-config branch 2 times, most recently from a66302f to cf5960a Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch 2 times, most recently from 1308c60 to 5a42229 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/harness-native-config branch from cf5960a to 0cc881b Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 5a42229 to a242d83 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/harness-native-config branch from 132b95d to a1b1777 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from a242d83 to 9938ec5 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/harness-native-config branch from a1b1777 to 5ad2af9 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 9938ec5 to 27a4de4 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/harness-native-config branch from 5ad2af9 to 6ba93f3 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 27a4de4 to 0ed8464 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from 0ed8464 to a774af9 Compare July 15, 2026 11:10
Delete the preset branch of load_and_process_config so load_native is the only
loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI
override parser (build_args_parser/update_config_map_by_command_args), the
load-time config_schema.json read, the pointer-resolution and #is_none-folding
functions (split_pointers_map, split_values_and_types,
update_config_map_by_pointers, update_optional_values), and the config_parity
dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS,
CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for
later phases.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/harness-native-config branch from 4834244 to ce5487d Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/native-sole-load branch from a774af9 to 2dd4a98 Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants