apollo_config: make native the sole config-load path#14631
Open
nimrod-starkware wants to merge 1 commit into
Open
apollo_config: make native the sole config-load path#14631nimrod-starkware wants to merge 1 commit into
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 25, 2026
This was referenced Jun 25, 2026
Contributor
Author
This was referenced Jun 25, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/config-serde-symmetric
branch
from
June 28, 2026 08:19
22984a6 to
407157e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
June 28, 2026 08:19
d8e24ea to
06da659
Compare
This was referenced Jun 28, 2026
Open
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
June 28, 2026 10:14
06da659 to
5eb5701
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/config-serde-symmetric
branch
from
June 28, 2026 10:14
407157e to
9b677ae
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
June 28, 2026 10:30
5eb5701 to
ec5b1f7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/config-serde-symmetric
branch
from
June 28, 2026 10:30
9b677ae to
de0822e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
2 times, most recently
from
July 12, 2026 08:50
443d831 to
ef8a7f6
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/config-serde-symmetric
branch
from
July 12, 2026 08:50
90ee096 to
c26fd0b
Compare
nimrod-starkware
left a comment
Contributor
Author
There was a problem hiding this comment.
@nimrod-starkware made 1 comment.
Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion (waiting on dan-starkware and matanl-starkware).
crates/apollo_config/src/loading.rs line 102 at r4 (raw file):
command: Command, args: Vec<String>, _ignore_default_values: bool,
remove
Code quote:
_ignore_default_values: bool,
nimrod-starkware
force-pushed
the
nimrod/jsonnet/config-serde-symmetric
branch
from
July 12, 2026 10:04
c26fd0b to
05266f9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 12, 2026 10:04
ef8a7f6 to
3f90357
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/config-serde-symmetric
branch
from
July 12, 2026 10:51
05266f9 to
c9c78dd
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 12, 2026 10:51
3f90357 to
3cd9d0b
Compare
nimrod-starkware
changed the base branch from
nimrod/jsonnet/config-serde-symmetric
to
graphite-base/14631
July 13, 2026 08:40
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 13, 2026 10:07
3cd9d0b to
99eb423
Compare
nimrod-starkware
changed the base branch from
graphite-base/14631
to
nimrod/jsonnet/harness-native-config
July 13, 2026 10:07
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 13, 2026 11:00
99eb423 to
d9bc8a3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/harness-native-config
branch
2 times, most recently
from
July 13, 2026 11:47
a66302f to
cf5960a
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
2 times, most recently
from
July 14, 2026 06:16
1308c60 to
5a42229
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/harness-native-config
branch
from
July 14, 2026 06:16
cf5960a to
0cc881b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 14, 2026 09:16
5a42229 to
a242d83
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/harness-native-config
branch
from
July 14, 2026 13:56
132b95d to
a1b1777
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 14, 2026 13:56
a242d83 to
9938ec5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/harness-native-config
branch
from
July 14, 2026 14:59
a1b1777 to
5ad2af9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 14, 2026 14:59
9938ec5 to
27a4de4
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/harness-native-config
branch
from
July 14, 2026 16:05
5ad2af9 to
6ba93f3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 14, 2026 16:05
27a4de4 to
0ed8464
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 15, 2026 11:10
0ed8464 to
a774af9
Compare
Delete the preset branch of load_and_process_config so load_native is the only loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI override parser (build_args_parser/update_config_map_by_command_args), the load-time config_schema.json read, the pointer-resolution and #is_none-folding functions (split_pointers_map, split_values_and_types, update_config_map_by_pointers, update_optional_values), and the config_parity dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS, CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for later phases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/harness-native-config
branch
from
July 15, 2026 11:26
4834244 to
ce5487d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/native-sole-load
branch
from
July 15, 2026 11:26
a774af9 to
2dd4a98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Delete the preset branch of load_and_process_config so load_native is the only
loader: remove the ConfigFormat enum + --config_format arg, the per-param CLI
override parser (build_args_parser/update_config_map_by_command_args), the
load-time config_schema.json read, the pointer-resolution and #is_none-folding
functions (split_pointers_map, split_values_and_types,
update_config_map_by_pointers, update_optional_values), and the config_parity
dev bin. Callers stop passing --config_format. Pointer/#is_none DEFINITIONS,
CONFIG_POINTERS, dump()/SerializeConfig, and CONFIG_SCHEMA_PATH are retained for
later phases.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com