deployment: drop redundant YAML sequencerConfig; source port-uniqueness from jsonnet#14659
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 28, 2026
Open
Contributor
Author
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 1, 2026 08:25
318f298 to
eeb95de
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 1, 2026 08:25
d023c32 to
ab563e6
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 2, 2026 14:20
ab563e6 to
cc1912c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 13, 2026 10:07
c41ed50 to
854a17f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 13, 2026 10:07
0e2e151 to
546b54f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 13, 2026 11:00
854a17f to
2a04c11
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 13, 2026 11:00
546b54f to
236fc75
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 13, 2026 11:47
2a04c11 to
9b20690
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
2 times, most recently
from
July 14, 2026 06:16
895a9a4 to
c143437
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 09:16
6262aa0 to
d3561ad
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 14, 2026 09:16
c143437 to
3524b26
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 09:54
d3561ad to
8126e15
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
2 times, most recently
from
July 14, 2026 10:47
bc74d75 to
fb28fa0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 10:47
8126e15 to
fa9633f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 14, 2026 11:32
fb28fa0 to
e430004
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 11:32
fa9633f to
2a68f9e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 14, 2026 13:48
2a68f9e to
2d70740
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
2 times, most recently
from
July 14, 2026 13:56
28f2eef to
7580524
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
2 times, most recently
from
July 14, 2026 14:11
6742e5b to
d6689b7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
3 times, most recently
from
July 14, 2026 16:05
78b6ab4 to
e9b08ee
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 15, 2026 11:10
e9b08ee to
c53548d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/remove-serialize-config
branch
from
July 15, 2026 11:20
17e9a82 to
9a99b1c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 15, 2026 11:20
c53548d to
765062b
Compare
…ss from jsonnet The cdk8s ConfigMap is built solely from the jsonnet override layers (build_native_config); the YAML config.sequencerConfig blocks are now redundant duplicate data. Delete them from every public hybrid overlay YAML (the env-specific values — chain_id, recorder_url, cache_size, fee tokens, ports — all live in the sequencer_config.jsonnet layers). Delete the lockstep parity tests that compared jsonnet to YAML (their YAML side is gone) and migrate test_port_uniqueness's within-service and cross-service component-port checks to read the built native config instead of YAML sequencerConfig, filtering port==0 (disabled components) and gaining coverage of the storage-reader/subsystem ports the YAML never enumerated. The schema.py sequencerConfig field and merger.py merge branch are deliberately kept: StrictBaseModel uses extra=forbid, so the loader must still accept devops-repo overlays that carry sequencerConfig until that out-of-repo cleanup lands. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/drop-yaml-sequencer-config
branch
from
July 15, 2026 11:26
765062b to
d9c9e0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The cdk8s ConfigMap is built solely from the jsonnet override layers (build_native_config); the YAML config.sequencerConfig blocks are now redundant duplicate data. Delete them from every public hybrid overlay YAML (the env-specific values — chain_id, recorder_url, cache_size, fee tokens, ports — all live in the sequencer_config.jsonnet layers). Delete the lockstep parity tests that compared jsonnet to YAML (their YAML side is gone) and migrate test_port_uniqueness's within-service and cross-service component-port checks to read the built native config instead of YAML sequencerConfig, filtering port==0 (disabled components) and gaining coverage of the storage-reader/subsystem ports the YAML never enumerated. The schema.py sequencerConfig field and merger.py merge branch are deliberately kept: StrictBaseModel uses extra=forbid, so the loader must still accept devops-repo overlays that carry sequencerConfig until that out-of-repo cleanup lands.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com