Skip to content

deployment: drop redundant YAML sequencerConfig; source port-uniqueness from jsonnet#14659

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/remove-serialize-configfrom
nimrod/jsonnet/drop-yaml-sequencer-config
Draft

deployment: drop redundant YAML sequencerConfig; source port-uniqueness from jsonnet#14659
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/remove-serialize-configfrom
nimrod/jsonnet/drop-yaml-sequencer-config

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

The cdk8s ConfigMap is built solely from the jsonnet override layers (build_native_config); the YAML config.sequencerConfig blocks are now redundant duplicate data. Delete them from every public hybrid overlay YAML (the env-specific values — chain_id, recorder_url, cache_size, fee tokens, ports — all live in the sequencer_config.jsonnet layers). Delete the lockstep parity tests that compared jsonnet to YAML (their YAML side is gone) and migrate test_port_uniqueness's within-service and cross-service component-port checks to read the built native config instead of YAML sequencerConfig, filtering port==0 (disabled components) and gaining coverage of the storage-reader/subsystem ports the YAML never enumerated. The schema.py sequencerConfig field and merger.py merge branch are deliberately kept: StrictBaseModel uses extra=forbid, so the loader must still accept devops-repo overlays that carry sequencerConfig until that out-of-repo cleanup lands.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

This was referenced Jun 28, 2026

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from c41ed50 to 854a17f Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from 0e2e151 to 546b54f Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 854a17f to 2a04c11 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from 546b54f to 236fc75 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 2a04c11 to 9b20690 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch 2 times, most recently from 895a9a4 to c143437 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 6262aa0 to d3561ad Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from c143437 to 3524b26 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from d3561ad to 8126e15 Compare July 14, 2026 09:54
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch 2 times, most recently from bc74d75 to fb28fa0 Compare July 14, 2026 10:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 8126e15 to fa9633f Compare July 14, 2026 10:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from fb28fa0 to e430004 Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from fa9633f to 2a68f9e Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 2a68f9e to 2d70740 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch 2 times, most recently from 28f2eef to 7580524 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch 2 times, most recently from 6742e5b to d6689b7 Compare July 14, 2026 14:11
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch 3 times, most recently from 78b6ab4 to e9b08ee Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from e9b08ee to c53548d Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/remove-serialize-config branch from 17e9a82 to 9a99b1c Compare July 15, 2026 11:20
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from c53548d to 765062b Compare July 15, 2026 11:20
…ss from jsonnet

The cdk8s ConfigMap is built solely from the jsonnet override layers (build_native_config); the YAML config.sequencerConfig blocks are now redundant duplicate data. Delete them from every public hybrid overlay YAML (the env-specific values — chain_id, recorder_url, cache_size, fee tokens, ports — all live in the sequencer_config.jsonnet layers). Delete the lockstep parity tests that compared jsonnet to YAML (their YAML side is gone) and migrate test_port_uniqueness's within-service and cross-service component-port checks to read the built native config instead of YAML sequencerConfig, filtering port==0 (disabled components) and gaining coverage of the storage-reader/subsystem ports the YAML never enumerated. The schema.py sequencerConfig field and merger.py merge branch are deliberately kept: StrictBaseModel uses extra=forbid, so the loader must still accept devops-repo overlays that carry sequencerConfig until that out-of-repo cleanup lands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/drop-yaml-sequencer-config branch from 765062b to d9c9e0b Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants