apollo_node_config: promote normalize_pointer_groups to shared config_utils test helper#14731
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jul 7, 2026
This was referenced Jul 7, 2026
Open
Draft
Contributor
Author
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
2 times, most recently
from
July 9, 2026 12:43
521f01a to
bf1f258
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 9, 2026 13:27
6a5f281 to
16190b9
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 9, 2026 13:27
bf1f258 to
29d2725
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 12, 2026 08:50
16190b9 to
f33eb63
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 12, 2026 08:50
29d2725 to
5d3cc95
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
2 times, most recently
from
July 12, 2026 13:24
4e28f22 to
92dfa83
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 13, 2026 10:07
25b5bce to
d5c97d6
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 13, 2026 10:07
92dfa83 to
71724fc
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 13, 2026 11:00
d5c97d6 to
9ce32ef
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
3 times, most recently
from
July 14, 2026 06:16
705017b to
62fb7d0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 14, 2026 09:16
4ce5b6e to
c119a6f
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 09:16
62fb7d0 to
79ebd04
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 13:48
79ebd04 to
d7a5ae8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
2 times, most recently
from
July 14, 2026 13:56
36fd208 to
f5d717f
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 13:56
d7a5ae8 to
a8d181c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 14, 2026 14:59
f5d717f to
55ede14
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
2 times, most recently
from
July 14, 2026 16:05
2b93b53 to
fce3fe1
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 15, 2026 11:10
fce3fe1 to
5aa57e9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 15, 2026 11:26
153fd1a to
788b0ba
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 15, 2026 11:26
5aa57e9 to
0846785
Compare
…_utils test helper Move the pointer-group normalization helper from config_test.rs to config_utils.rs as a pub #[cfg(any(feature = "testing", test))] fn so cross-crate tests can reuse it. Pure refactor: config_test remains the sole caller here. Adds starknet_api to [dependencies] since config_utils is a non-test source file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
July 20, 2026 10:55
788b0ba to
e42a1ec
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 20, 2026 10:55
0846785 to
8f3c1ee
Compare
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Move the pointer-group normalization helper from config_test.rs to config_utils.rs as a pub
#[cfg(any(feature = "testing", test))] fn so cross-crate tests can reuse it. Pure refactor:
config_test remains the sole caller here. Adds starknet_api to [dependencies] since config_utils is
a non-test source file.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com