Skip to content

apollo_node_config: promote normalize_pointer_groups to shared config_utils test helper#14731

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/validate-cross-component-equalityfrom
externalize-normalize-pointer-groups
Draft

apollo_node_config: promote normalize_pointer_groups to shared config_utils test helper#14731
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/validate-cross-component-equalityfrom
externalize-normalize-pointer-groups

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Move the pointer-group normalization helper from config_test.rs to config_utils.rs as a pub
#[cfg(any(feature = "testing", test))] fn so cross-crate tests can reuse it. Pure refactor:
config_test remains the sole caller here. Adds starknet_api to [dependencies] since config_utils is
a non-test source file.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

This was referenced Jul 7, 2026

nimrod-starkware commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch 2 times, most recently from 521f01a to bf1f258 Compare July 9, 2026 12:43
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 6a5f281 to 16190b9 Compare July 9, 2026 13:27
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from bf1f258 to 29d2725 Compare July 9, 2026 13:27
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 16190b9 to f33eb63 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 29d2725 to 5d3cc95 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch 2 times, most recently from 4e28f22 to 92dfa83 Compare July 12, 2026 13:24
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 25b5bce to d5c97d6 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 92dfa83 to 71724fc Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from d5c97d6 to 9ce32ef Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch 3 times, most recently from 705017b to 62fb7d0 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 4ce5b6e to c119a6f Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 62fb7d0 to 79ebd04 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 79ebd04 to d7a5ae8 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch 2 times, most recently from 36fd208 to f5d717f Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from d7a5ae8 to a8d181c Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from f5d717f to 55ede14 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch 2 times, most recently from 2b93b53 to fce3fe1 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from fce3fe1 to 5aa57e9 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 153fd1a to 788b0ba Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 5aa57e9 to 0846785 Compare July 15, 2026 11:26
…_utils test helper

Move the pointer-group normalization helper from config_test.rs to config_utils.rs as a pub
#[cfg(any(feature = "testing", test))] fn so cross-crate tests can reuse it. Pure refactor:
config_test remains the sole caller here. Adds starknet_api to [dependencies] since config_utils is
a non-test source file.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants