apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648
Open
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
Open
Contributor
Author
This was referenced Jun 28, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
June 28, 2026 10:14
89ab258 to
c0351e0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
June 28, 2026 10:14
84755fc to
3c4b392
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
June 28, 2026 10:30
3c4b392 to
dbff560
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
June 28, 2026 14:04
4f5f772 to
ece79f9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
June 28, 2026 14:04
dbff560 to
16c545d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 9, 2026 10:29
5706185 to
5f2bcb8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 9, 2026 10:29
cce749a to
361a2df
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 9, 2026 12:43
5f2bcb8 to
b6d2b7e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
2 times, most recently
from
July 9, 2026 13:27
3569fc5 to
ea9032b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 12, 2026 08:50
15f18dd to
b5c38a5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
3 times, most recently
from
July 12, 2026 10:51
fd53651 to
f656b23
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 13, 2026 10:07
40c21a1 to
a21c530
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 13, 2026 10:07
f656b23 to
6d99d57
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 13, 2026 11:00
a21c530 to
42d9a4f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
2 times, most recently
from
July 13, 2026 11:47
2364dd5 to
1650f42
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 13, 2026 11:47
42d9a4f to
0c5ceb7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 06:16
1650f42 to
e47a3e8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
from
July 14, 2026 09:16
33a4d9f to
3daf971
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 09:16
e47a3e8 to
375f3bf
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 13:48
375f3bf to
f981dad
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-replacer-generation
branch
2 times, most recently
from
July 14, 2026 13:56
4ecb1a1 to
9f70ed4
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
3 times, most recently
from
July 14, 2026 16:05
6fde139 to
dcaeb84
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 15, 2026 11:10
dcaeb84 to
b760dd4
Compare
…from secrets schema private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime, removing the runtime dependency on both. Delete the value config_schema.json (4147 lines) and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile. Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and split the up-to-date guard to assert only the secrets schema. A transient equivalence test (private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later SerializeConfig/CONFIG_POINTERS teardown. config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and apollo_deployments 9/9 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 15, 2026 11:26
b760dd4 to
c4e28b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.
config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com