Skip to content

apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-replacer-generationfrom
nimrod/jsonnet/source-private-params-from-secrets-schema
Open

apollo_node_config,apollo_node,deployment: source private_parameters from secrets schema, drop value config schema#14648
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/retire-replacer-generationfrom
nimrod/jsonnet/source-private-params-from-secrets-schema

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.

config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 89ab258 to c0351e0 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 84755fc to 3c4b392 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 3c4b392 to dbff560 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 4f5f772 to ece79f9 Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from dbff560 to 16c545d Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 5706185 to 5f2bcb8 Compare July 9, 2026 10:29
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from cce749a to 361a2df Compare July 9, 2026 10:29
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 5f2bcb8 to b6d2b7e Compare July 9, 2026 12:43
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch 2 times, most recently from 3569fc5 to ea9032b Compare July 9, 2026 13:27
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 15f18dd to b5c38a5 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch 3 times, most recently from fd53651 to f656b23 Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 40c21a1 to a21c530 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from f656b23 to 6d99d57 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from a21c530 to 42d9a4f Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch 2 times, most recently from 2364dd5 to 1650f42 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 42d9a4f to 0c5ceb7 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 1650f42 to e47a3e8 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch from 33a4d9f to 3daf971 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from e47a3e8 to 375f3bf Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 375f3bf to f981dad Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-replacer-generation branch 2 times, most recently from 4ecb1a1 to 9f70ed4 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch 3 times, most recently from 6fde139 to dcaeb84 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from dcaeb84 to b760dd4 Compare July 15, 2026 11:10
…from secrets schema

private_parameters() now reads the committed config_secrets_schema.json (a BTreeSet of
ParamPath) instead of deriving from config_schema.json + CONFIG_POINTERS at runtime,
removing the runtime dependency on both. Delete the value config_schema.json (4147 lines)
and the CONFIG_SCHEMA_PATH const (the native loader never read it; the per-param CLI
parser that did is gone), and remove its now-broken COPY from the sequencer Dockerfile.
Repurpose update_apollo_node_config_schema to regenerate ONLY the secrets schema, and
split the up-to-date guard to assert only the secrets schema. A transient equivalence test
(private_parameters_matches_config_dump_derivation) proves the file-sourced set equals the
old dump()+CONFIG_POINTERS derivation (no drift); it is marked for removal with the later
SerializeConfig/CONFIG_POINTERS teardown.

config_secrets_schema.json regenerates byte-identical; apollo_node_config 30/30 and
apollo_deployments 9/9 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from b760dd4 to c4e28b5 Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants