Skip to content

deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/testing-overlays-native-layersfrom
nimrod/jsonnet/retire-preset-config-path
Open

deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/testing-overlays-native-layersfrom
nimrod/jsonnet/retire-preset-config-path

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:

  • Delete the --config_format container arg (pod_builder) and the whole config_format
    plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
    constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
    the Rust node's parser, so emitting it to the container made the node panic on an
    unknown arg; the node now receives only --config_file. Verified by running the node
    on a synthesized native ConfigMap (reaches 'Finished loading configuration').
  • Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
    machinery (loaders.py); ConfigMap is always built via build_native_config.
  • Remove the two preset-parity python tests + their preset-only helpers; keep all native
    mirror/deep-merge/port tests.

All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 0df4a4a to a07b98f Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 39a3bb3 to e704bbc Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from e704bbc to b9c5305 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a07b98f to a3d7879 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from b9c5305 to 66a55ac Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a3d7879 to 4dfdb44 Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 765b381 to 72d7074 Compare July 9, 2026 13:27
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from bd1f483 to 85fd8ed Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch 2 times, most recently from 25152e6 to e03f18e Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch 2 times, most recently from ddcc508 to f6e5aa5 Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch 2 times, most recently from 74ecb08 to 626a03c Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from f6e5aa5 to 3ef6547 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 626a03c to 9bcf85d Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch 2 times, most recently from 808c9ad to e769b4b Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 9bcf85d to b01aab0 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from e769b4b to eced64e Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from b01aab0 to c682d4d Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from eced64e to b385629 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from c682d4d to 816d736 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from b385629 to e9fdab1 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 816d736 to a53f640 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from e9fdab1 to c516146 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a53f640 to 8f99f07 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from c516146 to b966715 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch 2 times, most recently from 2e9532b to a9fa937 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 3b0cd38 to 9a2dc4e Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from a9fa937 to 3003d96 Compare July 15, 2026 11:10
… preset config path

Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
- Delete the --config_format container arg (pod_builder) and the whole config_format
  plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
  constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
  the Rust node's parser, so emitting it to the container made the node panic on an
  unknown arg; the node now receives only --config_file. Verified by running the node
  on a synthesized native ConfigMap (reaches 'Finished loading configuration').
- Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
  machinery (loaders.py); ConfigMap is always built via build_native_config.
- Remove the two preset-parity python tests + their preset-only helpers; keep all native
  mirror/deep-merge/port tests.

All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-path branch from 3003d96 to d41c665 Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants