deployment,apollo_deployments: drop config_format plumbing and retire preset config path#14646
Open
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
June 28, 2026 10:14
0df4a4a to
a07b98f
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
June 28, 2026 10:14
39a3bb3 to
e704bbc
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
June 28, 2026 10:30
e704bbc to
b9c5305
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
June 28, 2026 10:30
a07b98f to
a3d7879
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
June 28, 2026 14:04
b9c5305 to
66a55ac
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
June 28, 2026 14:04
a3d7879 to
4dfdb44
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 9, 2026 13:27
765b381 to
72d7074
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 12, 2026 08:50
bd1f483 to
85fd8ed
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
2 times, most recently
from
July 12, 2026 10:04
25152e6 to
e03f18e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
2 times, most recently
from
July 12, 2026 10:51
ddcc508 to
f6e5aa5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
2 times, most recently
from
July 13, 2026 10:07
74ecb08 to
626a03c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 13, 2026 10:07
f6e5aa5 to
3ef6547
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 13, 2026 11:00
626a03c to
9bcf85d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
2 times, most recently
from
July 13, 2026 11:47
808c9ad to
e769b4b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 13, 2026 11:47
9bcf85d to
b01aab0
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 14, 2026 06:16
e769b4b to
eced64e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 06:16
b01aab0 to
c682d4d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 14, 2026 09:16
eced64e to
b385629
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 09:16
c682d4d to
816d736
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 14, 2026 13:48
b385629 to
e9fdab1
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 13:48
816d736 to
a53f640
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 14, 2026 13:56
e9fdab1 to
c516146
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 14, 2026 13:56
a53f640 to
8f99f07
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 14, 2026 14:59
c516146 to
b966715
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
2 times, most recently
from
July 14, 2026 16:05
2e9532b to
a9fa937
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/testing-overlays-native-layers
branch
from
July 15, 2026 11:10
3b0cd38 to
9a2dc4e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 15, 2026 11:10
a9fa937 to
3003d96
Compare
… preset config path
Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
- Delete the --config_format container arg (pod_builder) and the whole config_format
plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
the Rust node's parser, so emitting it to the container made the node panic on an
unknown arg; the node now receives only --config_file. Verified by running the node
on a synthesized native ConfigMap (reaches 'Finished loading configuration').
- Retire the python preset path: delete NodeConfigLoader and the $$$ placeholder-fill
machinery (loaders.py); ConfigMap is always built via build_native_config.
- Remove the two preset-parity python tests + their preset-only helpers; keep all native
mirror/deep-merge/port tests.
All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-path
branch
from
July 15, 2026 11:26
3003d96 to
d41c665
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Make native the sole config path in the cdk8s deploy and remove the now-dead
preset machinery:
plumbing (cli.py --config-format flag + threading through app.py, charts/node.py,
constructs/{deployment,statefulset,configmap}). Phase 1 removed --config_format from
the Rust node's parser, so emitting it to the container made the node panic on an
unknown arg; the node now receives only --config_file. Verified by running the node
on a synthesized native ConfigMap (reaches 'Finished loading configuration').
machinery (loaders.py); ConfigMap is always built via build_native_config.
mirror/deep-merge/port tests.
All hybrid overlays (mainnet, sepolia-alpha, sepolia-integration, testing/node-0,
testing/all-constructs) synth nested native; no synthesized container passes
--config_format; pytest test/ green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com