Skip to content

apollo_deployments: delete Rust component-config topology mirror#14688

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/build-component-configsfrom
nimrod/jsonnet/delete-get-component-configs
Draft

apollo_deployments: delete Rust component-config topology mirror#14688
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/build-component-configsfrom
nimrod/jsonnet/delete-get-component-configs

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Now that the integration-test harness sources component configs from jsonnet
build(), remove get_component_configs and everything that existed only to serve
it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the
ScalePolicy module, per-service config builders, the mirror-parity tests and
their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

nimrod-starkware commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 3 times, most recently from de8a987 to e865d55 Compare July 5, 2026 10:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from 7e3ab7c to 827bb92 Compare July 6, 2026 08:03
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch from e865d55 to 3ee6157 Compare July 6, 2026 08:03
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch from 4b717fb to 317679e Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from a38b4fe to 6174e92 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 2 times, most recently from 516139c to e965a71 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch 2 times, most recently from e32924d to f7a764e Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 2 times, most recently from 70ed407 to fe1eb54 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from 98f1f02 to 35a6ed9 Compare July 14, 2026 09:54
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 2 times, most recently from 401ee2e to 17e9174 Compare July 14, 2026 10:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch 2 times, most recently from b072a53 to 81c90f2 Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch from 17e9174 to 701eba8 Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from 81c90f2 to c09a6a9 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 2 times, most recently from 8e7d540 to f542cfb Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from 257a60c to 6d2c9aa Compare July 14, 2026 14:11
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 2 times, most recently from 0785e46 to 5b0a34e Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from 6d2c9aa to 3b87c53 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch from 5b0a34e to f50d621 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from 374076c to c903f27 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch 2 times, most recently from 1d9fed5 to f4215c7 Compare July 15, 2026 11:20
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/build-component-configs branch from c903f27 to 021969b Compare July 15, 2026 11:20
Now that the integration-test harness sources component configs from jsonnet
build(), remove get_component_configs and everything that existed only to serve
it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the
ScalePolicy module, per-service config builders, the mirror-parity tests and
their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-get-component-configs branch from f4215c7 to eab7695 Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants