apollo_deployments: delete Rust component-config topology mirror#14688
Draft
nimrod-starkware wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 2, 2026
This was referenced Jul 2, 2026
Open
Contributor
Author
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
3 times, most recently
from
July 5, 2026 10:26
de8a987 to
e865d55
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 6, 2026 08:03
7e3ab7c to
827bb92
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
from
July 6, 2026 08:03
e865d55 to
3ee6157
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
from
July 13, 2026 10:07
4b717fb to
317679e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 13, 2026 11:00
a38b4fe to
6174e92
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
2 times, most recently
from
July 13, 2026 11:47
516139c to
e965a71
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
2 times, most recently
from
July 14, 2026 06:16
e32924d to
f7a764e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
2 times, most recently
from
July 14, 2026 09:16
70ed407 to
fe1eb54
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 14, 2026 09:54
98f1f02 to
35a6ed9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
2 times, most recently
from
July 14, 2026 10:47
401ee2e to
17e9174
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
2 times, most recently
from
July 14, 2026 11:32
b072a53 to
81c90f2
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
from
July 14, 2026 11:32
17e9174 to
701eba8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 14, 2026 13:48
81c90f2 to
c09a6a9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
2 times, most recently
from
July 14, 2026 13:56
8e7d540 to
f542cfb
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 14, 2026 14:11
257a60c to
6d2c9aa
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
2 times, most recently
from
July 14, 2026 14:59
0785e46 to
5b0a34e
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 14, 2026 14:59
6d2c9aa to
3b87c53
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
from
July 14, 2026 16:05
5b0a34e to
f50d621
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 15, 2026 11:10
374076c to
c903f27
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
2 times, most recently
from
July 15, 2026 11:20
1d9fed5 to
f4215c7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/build-component-configs
branch
from
July 15, 2026 11:20
c903f27 to
021969b
Compare
Now that the integration-test harness sources component configs from jsonnet build(), remove get_component_configs and everything that existed only to serve it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the ScalePolicy module, per-service config builders, the mirror-parity tests and their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-get-component-configs
branch
from
July 15, 2026 11:26
f4215c7 to
eab7695
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now that the integration-test harness sources component configs from jsonnet
build(), remove get_component_configs and everything that existed only to serve
it: the GetComponentConfigs trait, ComponentConfigPair, InfraPortAllocator, the
ScalePolicy module, per-service config builders, the mirror-parity tests and
their jsonnet renderers, and the now-unused apollo_infra / static_assertions deps.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com