deployment: add native config layers for the testing overlays#14645
Conversation
39a3bb3 to
e704bbc
Compare
e704bbc to
b9c5305
Compare
082340c to
8852b34
Compare
b9c5305 to
66a55ac
Compare
f81e54a to
3df4b69
Compare
85fd8ed to
ddcc508
Compare
3df4b69 to
c07fbbb
Compare
ddcc508 to
f6e5aa5
Compare
b3a97b1 to
c69700d
Compare
f6e5aa5 to
3ef6547
Compare
c69700d to
ab65bfe
Compare
3ef6547 to
808c9ad
Compare
ab65bfe to
f9b228c
Compare
808c9ad to
e769b4b
Compare
f9b228c to
e4a3050
Compare
eced64e to
b385629
Compare
e9fdab1 to
c516146
Compare
06e45e8 to
de17696
Compare
b966715 to
3b0cd38
Compare
de17696 to
2207acc
Compare
3b0cd38 to
9a2dc4e
Compare
2207acc to
50dcbd4
Compare
50dcbd4 to
e47efc7
Compare
9a2dc4e to
987a5af
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 987a5af. Configure here.
|
|
||
|
|
||
| def test_node_0_native_matches_yaml(): | ||
| assert_env_overlay_matches_yaml(HYBRID_OVERLAYS_DIR / "testing" / "node-0") |
There was a problem hiding this comment.
Node-0 YAML parity test fails
Medium Severity
The new test_node_0_native_matches_yaml guard is meant to enforce value parity for a load-bearing overlay, but _layer_bucketed_override_flat leaves compare_retrospective_block_hash unmapped while folded YAML only exposes consensus_manager_config.context_config.dynamic_config.compare_retrospective_block_hash. It also emits state_sync_config.static_config.p2p_sync_client_config as {}, which folded YAML never records when the overlay only sets #is_none: false.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 987a5af. Configure here.



Under the native config path an overlay's config comes from sequencer_config.jsonnet
layers (YAML sequencerConfig is ignored). The testing/node-0 and testing/all-constructs
overlays (synthed by the cdk8s-test and hybrid-system-test CI jobs) had no native layer,
so native synth aborted on unconditionally-read overrides.* keys (validator_id, the outer
committer cache_size, ...).
YAML sequencerConfig). It is deployed live by hybrid_system_test, so values are
load-bearing; guarded by a strict mirror test (test_node0_layer_jsonnet_mirrors_combined_yaml).
overrides.* reads the base layer does not provide, with clearly-dummy immaterial values
(its synth is only kubectl-validated for manifest structure); guarded by a synth-success
test (test_all_constructs_native_config_synthesizes).
This lets every CI-synthed overlay build under native, before the default flip.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com