Skip to content

deployment: add native config layers for the testing overlays#14645

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/dummy-for-testing-native-layerfrom
nimrod/jsonnet/testing-overlays-native-layers
Open

deployment: add native config layers for the testing overlays#14645
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/dummy-for-testing-native-layerfrom
nimrod/jsonnet/testing-overlays-native-layers

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Under the native config path an overlay's config comes from sequencer_config.jsonnet
layers (YAML sequencerConfig is ignored). The testing/node-0 and testing/all-constructs
overlays (synthed by the cdk8s-test and hybrid-system-test CI jobs) had no native layer,
so native synth aborted on unconditionally-read overrides.* keys (validator_id, the outer
committer cache_size, ...).

  • testing/node-0: full value-parity native layer (the folded translation of its combined
    YAML sequencerConfig). It is deployed live by hybrid_system_test, so values are
    load-bearing; guarded by a strict mirror test (test_node0_layer_jsonnet_mirrors_combined_yaml).
  • testing/all-constructs: a structure-validation stub supplying exactly the unconditional
    overrides.* reads the base layer does not provide, with clearly-dummy immaterial values
    (its synth is only kubectl-validated for manifest structure); guarded by a synth-success
    test (test_all_constructs_native_config_synthesizes).

This lets every CI-synthed overlay build under native, before the default flip.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 39a3bb3 to e704bbc Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from e704bbc to b9c5305 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 082340c to 8852b34 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from b9c5305 to 66a55ac Compare June 28, 2026 14:04
@nimrod-starkware nimrod-starkware self-assigned this Jun 29, 2026
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from f81e54a to 3df4b69 Compare July 12, 2026 08:50
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 85fd8ed to ddcc508 Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 3df4b69 to c07fbbb Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from ddcc508 to f6e5aa5 Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch 2 times, most recently from b3a97b1 to c69700d Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from f6e5aa5 to 3ef6547 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from c69700d to ab65bfe Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 3ef6547 to 808c9ad Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from ab65bfe to f9b228c Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 808c9ad to e769b4b Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from f9b228c to e4a3050 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch 2 times, most recently from eced64e to b385629 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch 2 times, most recently from e9fdab1 to c516146 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 06e45e8 to de17696 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch 2 times, most recently from b966715 to 3b0cd38 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from de17696 to 2207acc Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 3b0cd38 to 9a2dc4e Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 2207acc to 50dcbd4 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/dummy-for-testing-native-layer branch from 50dcbd4 to e47efc7 Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/testing-overlays-native-layers branch from 9a2dc4e to 987a5af Compare July 15, 2026 11:26

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 987a5af. Configure here.



def test_node_0_native_matches_yaml():
assert_env_overlay_matches_yaml(HYBRID_OVERLAYS_DIR / "testing" / "node-0")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node-0 YAML parity test fails

Medium Severity

The new test_node_0_native_matches_yaml guard is meant to enforce value parity for a load-bearing overlay, but _layer_bucketed_override_flat leaves compare_retrospective_block_hash unmapped while folded YAML only exposes consensus_manager_config.context_config.dynamic_config.compare_retrospective_block_hash. It also emits state_sync_config.static_config.p2p_sync_client_config as {}, which folded YAML never records when the overlay only sets #is_none: false.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 987a5af. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants