apollo_deployments: delete base app_configs and the preset-parity test machinery#14649
Open
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
Open
Contributor
Author
This was referenced Jun 28, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
June 28, 2026 10:14
a4eefa9 to
ec8f72b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
June 28, 2026 10:30
3c4b392 to
dbff560
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
2 times, most recently
from
June 28, 2026 14:04
9ecf4fe to
e84d1fc
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
5 times, most recently
from
July 13, 2026 11:47
ffec769 to
32b8ead
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 13, 2026 11:47
2364dd5 to
1650f42
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 14, 2026 06:16
32b8ead to
adc0cd3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 06:16
1650f42 to
e47a3e8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 14, 2026 09:16
adc0cd3 to
51cc7f3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 09:16
e47a3e8 to
375f3bf
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 13:48
375f3bf to
f981dad
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
2 times, most recently
from
July 14, 2026 13:56
e7b7224 to
d621349
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 13:56
f981dad to
8ae41fb
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 14, 2026 14:59
d621349 to
c14d6f7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
from
July 14, 2026 16:05
6fde139 to
dcaeb84
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 14, 2026 16:05
c14d6f7 to
700dfc5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 15, 2026 11:10
700dfc5 to
bc88670
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/source-private-params-from-secrets-schema
branch
2 times, most recently
from
July 15, 2026 11:26
b760dd4 to
c4e28b5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 15, 2026 11:26
bc88670 to
9a22761
Compare
…t machinery
jsonnet build() is the sole source of the node config, so the committed base
app_configs/*_config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *_config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config_{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_*_deserializes + *_infra_matches_rust guards (later phases own those).
apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-base-app-configs
branch
from
July 20, 2026 10:55
9a22761 to
640690a
Compare
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

jsonnet build() is the sole source of the node config, so the committed base
app_configs/config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_deserializes + *_infra_matches_rust guards (later phases own those).
apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com