Skip to content

apollo_deployments: delete base app_configs and the preset-parity test machinery#14649

Open
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/source-private-params-from-secrets-schemafrom
nimrod/jsonnet/delete-base-app-configs
Open

apollo_deployments: delete base app_configs and the preset-parity test machinery#14649
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/source-private-params-from-secrets-schemafrom
nimrod/jsonnet/delete-base-app-configs

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

jsonnet build() is the sole source of the node config, so the committed base
app_configs/config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config
{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build
_deserializes + *_infra_matches_rust guards (later phases own those).

apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch 5 times, most recently from ffec769 to 32b8ead Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 2364dd5 to 1650f42 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from 32b8ead to adc0cd3 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 1650f42 to e47a3e8 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from adc0cd3 to 51cc7f3 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from e47a3e8 to 375f3bf Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 375f3bf to f981dad Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch 2 times, most recently from e7b7224 to d621349 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from f981dad to 8ae41fb Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from d621349 to c14d6f7 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch from 6fde139 to dcaeb84 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from c14d6f7 to 700dfc5 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from 700dfc5 to bc88670 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/source-private-params-from-secrets-schema branch 2 times, most recently from b760dd4 to c4e28b5 Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-base-app-configs branch from bc88670 to 9a22761 Compare July 15, 2026 11:26
…t machinery

jsonnet build() is the sole source of the node config, so the committed base
app_configs/*_config.json and the build()-vs-app_configs parity test are dead.
Delete the 21 base *_config.json, merged_app_configs/non_default_paths/
test_applicative_matches_app_configs and the applicative_matches_app_configs test,
plus their last-user constants KEYS_TO_BE_REPLACED and BASE_APP_CONFIGS_DIR_PATH
(and the now-dead get_component_config_{names,file_paths}), and drop the freed phf
dep. Keep CONFIG_POINTERS/dump()/config_to_preset definitions and the
build_*_deserializes + *_infra_matches_rust guards (later phases own those).

apollo_deployments 8/8 green; cdk8s synth 31/31 green (build() sole source).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants