apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path#14651
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
This was referenced Jun 28, 2026
Contributor
Author
This was referenced Jun 28, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
June 28, 2026 10:14
5257d79 to
e1fdf85
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
June 28, 2026 10:14
7644cf5 to
31be7f8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
June 28, 2026 10:30
31be7f8 to
c0d2f48
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/validate-cross-component-equality
branch
from
June 28, 2026 14:04
614e204 to
b42f836
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
June 28, 2026 14:04
c0d2f48 to
4e8c344
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
2 times, most recently
from
July 12, 2026 10:04
5d3cc95 to
4d75ed3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
2 times, most recently
from
July 12, 2026 10:51
014dd60 to
fe9c3da
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 12, 2026 13:24
4e28f22 to
92dfa83
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
2 times, most recently
from
July 13, 2026 10:07
2600d0b to
f458348
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 13, 2026 11:00
71724fc to
512c67c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 13, 2026 11:00
f458348 to
09497c7
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 13, 2026 11:47
512c67c to
705017b
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
6 times, most recently
from
July 14, 2026 11:32
bbc7f49 to
12340ba
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 13:48
79ebd04 to
d7a5ae8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 14, 2026 13:48
12340ba to
9de4774
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 13:56
d7a5ae8 to
a8d181c
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 14, 2026 13:56
9de4774 to
253bf0d
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 14:59
a8d181c to
2b93b53
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 14, 2026 14:59
253bf0d to
1abce2b
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 14, 2026 16:05
2b93b53 to
fce3fe1
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 14, 2026 16:05
1abce2b to
40ddd9d
Compare
nimrod-starkware
force-pushed
the
externalize-normalize-pointer-groups
branch
from
July 15, 2026 11:10
fce3fe1 to
5aa57e9
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 15, 2026 11:10
40ddd9d to
20b1f71
Compare
…tire preset config generation
Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).
This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/retire-preset-config-generation
branch
from
July 15, 2026 11:26
20b1f71 to
4dd731b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).
This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com