Skip to content

apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path#14651

Draft
nimrod-starkware wants to merge 1 commit into
externalize-normalize-pointer-groupsfrom
nimrod/jsonnet/retire-preset-config-generation
Draft

apollo_node_config,apollo_config_manager,apollo_integration_tests: retire preset config-generation path#14651
nimrod-starkware wants to merge 1 commit into
externalize-normalize-pointer-groupsfrom
nimrod/jsonnet/retire-preset-config-generation

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).

This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 5257d79 to e1fdf85 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 7644cf5 to 31be7f8 Compare June 28, 2026 10:14
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 31be7f8 to c0d2f48 Compare June 28, 2026 10:30
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/validate-cross-component-equality branch from 614e204 to b42f836 Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from c0d2f48 to 4e8c344 Compare June 28, 2026 14:04
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch 2 times, most recently from 5d3cc95 to 4d75ed3 Compare July 12, 2026 10:04
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch 2 times, most recently from 014dd60 to fe9c3da Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 4e28f22 to 92dfa83 Compare July 12, 2026 13:24
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch 2 times, most recently from 2600d0b to f458348 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 71724fc to 512c67c Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from f458348 to 09497c7 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 512c67c to 705017b Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch 6 times, most recently from bbc7f49 to 12340ba Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 79ebd04 to d7a5ae8 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 12340ba to 9de4774 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from d7a5ae8 to a8d181c Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 9de4774 to 253bf0d Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from a8d181c to 2b93b53 Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 253bf0d to 1abce2b Compare July 14, 2026 14:59
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from 2b93b53 to fce3fe1 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 1abce2b to 40ddd9d Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the externalize-normalize-pointer-groups branch from fce3fe1 to 5aa57e9 Compare July 15, 2026 11:10
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 40ddd9d to 20b1f71 Compare July 15, 2026 11:10
…tire preset config generation

Delete the flat-preset config generation now that everything loads native: remove
ConfigPointersMap and DeploymentBaseAppConfig::{as_value, dump_config_file,
config_pointers_map, get/modify_config_pointers, validate_all_pointer_targets_set}.
Migrate the integration-test setup and config_manager_runner_tests off the pointer-
resolved as_value path to the native as_native_value path (the config_manager test was
already failing at HEAD: it passed a single --config_file but native load requires two).
Promote normalize_pointer_groups to a shared cfg(testing/test) helper in config_utils.
create_node_config now sets validator_id directly on the real struct (the native dump
ignored the pointer map).

This unblocks deleting CONFIG_POINTERS (its only remaining consumers are the secrets-schema
bin + the transient equivalence test). apollo_config_manager 15/15, apollo_node_config
34/34, apollo_deployments 8/8 green; integration bins compile.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/retire-preset-config-generation branch from 20b1f71 to 4dd731b Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants