Skip to content

apollo_config,apollo_node_config,apollo_config_manager: rework get_config_presentation off dump()#14653

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/delete-config-pointersfrom
nimrod/jsonnet/presentation-off-dump
Draft

apollo_config,apollo_node_config,apollo_config_manager: rework get_config_presentation off dump()#14653
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/delete-config-pointersfrom
nimrod/jsonnet/presentation-off-dump

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

get_config_presentation was the last native-path consumer of dump() (it used dump() only
as a privacy registry to redact Private params from the startup-log / config-diff
presentation). Rework it to take an injected private-path set:
get_config_presentation<T: Serialize>(config, include_private_parameters, private_paths)
— dropping the SerializeConfig bound. Callers (load_and_validate_config startup log,
config_manager diff) inject &private_parameters() (the committed config_secrets_schema.json
set). The injected set equals the old dump()-derived Private set exactly (is_private() ==
privacy==Private), so redaction is preserved with no leak / no over-redaction; a new
no-leak test guards it. remove_path_from_json (the redaction mechanism) is retained.

This unblocks deleting dump()/SerializeConfig in Phase 9. apollo_config 27+4,
apollo_config_manager 15, apollo_node_config 33, apollo_deployments 8 green.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

nimrod-starkware commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 30fea6b to f6c9031 Compare July 12, 2026 10:51
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from 03fc9a5 to 4c48953 Compare July 12, 2026 13:24
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch 2 times, most recently from 778fa43 to 9042cc1 Compare July 13, 2026 10:07
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from 7da9229 to b789345 Compare July 13, 2026 11:00
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch 2 times, most recently from 23c8108 to 35763d3 Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from b789345 to 08b08ac Compare July 13, 2026 11:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 35763d3 to f32a272 Compare July 14, 2026 06:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch 2 times, most recently from e1590d6 to bc2994d Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from f32a272 to 8a7e8d7 Compare July 14, 2026 09:16
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from bc2994d to a21e87d Compare July 14, 2026 09:54
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch 2 times, most recently from 34bfe37 to ab93bfe Compare July 14, 2026 10:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from a21e87d to 127579a Compare July 14, 2026 10:47
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from ab93bfe to 55a1ab5 Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from 127579a to 6a977e8 Compare July 14, 2026 11:32
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 55a1ab5 to 6971a62 Compare July 14, 2026 13:48
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch 2 times, most recently from 6027cd4 to b17a259 Compare July 14, 2026 13:56
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch 3 times, most recently from a573227 to c9c6e85 Compare July 14, 2026 16:05
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from c9c6e85 to 9f39d9b Compare July 15, 2026 11:10
…nfig_presentation off dump()

get_config_presentation was the last native-path consumer of dump() (it used dump() only
as a privacy registry to redact Private params from the startup-log / config-diff
presentation). Rework it to take an injected private-path set:
get_config_presentation<T: Serialize>(config, include_private_parameters, private_paths)
— dropping the SerializeConfig bound. Callers (load_and_validate_config startup log,
config_manager diff) inject &private_parameters() (the committed config_secrets_schema.json
set). The injected set equals the old dump()-derived Private set exactly (is_private() ==
privacy==Private), so redaction is preserved with no leak / no over-redaction; a new
no-leak test guards it. remove_path_from_json (the redaction mechanism) is retained.

This unblocks deleting dump()/SerializeConfig in Phase 9. apollo_config 27+4,
apollo_config_manager 15, apollo_node_config 33, apollo_deployments 8 green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/delete-config-pointers branch from 3a820fb to bf6cdb3 Compare July 15, 2026 11:26
@nimrod-starkware
nimrod-starkware force-pushed the nimrod/jsonnet/presentation-off-dump branch from 9f39d9b to a1eee5e Compare July 15, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants