apollo_config,apollo_node_config,apollo_config_manager: rework get_config_presentation off dump()#14653
Draft
nimrod-starkware wants to merge 1 commit into
Conversation
This was referenced Jun 28, 2026
Open
Contributor
Author
This was referenced Jun 28, 2026
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
June 28, 2026 10:14
452bc9e to
98aaff6
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
June 28, 2026 10:14
7503a2b to
102de97
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
June 28, 2026 10:30
102de97 to
11caafd
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
2 times, most recently
from
June 28, 2026 14:04
198918e to
853a39d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
June 28, 2026 14:04
11caafd to
3096831
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 12, 2026 10:51
30fea6b to
f6c9031
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 12, 2026 13:24
03fc9a5 to
4c48953
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
2 times, most recently
from
July 13, 2026 10:07
778fa43 to
9042cc1
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 13, 2026 11:00
7da9229 to
b789345
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
2 times, most recently
from
July 13, 2026 11:47
23c8108 to
35763d3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 13, 2026 11:47
b789345 to
08b08ac
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 06:16
35763d3 to
f32a272
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
2 times, most recently
from
July 14, 2026 09:16
e1590d6 to
bc2994d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 09:16
f32a272 to
8a7e8d7
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 14, 2026 09:54
bc2994d to
a21e87d
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
2 times, most recently
from
July 14, 2026 10:47
34bfe37 to
ab93bfe
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 14, 2026 10:47
a21e87d to
127579a
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 11:32
ab93bfe to
55a1ab5
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 14, 2026 11:32
127579a to
6a977e8
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 14, 2026 13:48
55a1ab5 to
6971a62
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
2 times, most recently
from
July 14, 2026 13:56
6027cd4 to
b17a259
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
3 times, most recently
from
July 14, 2026 16:05
a573227 to
c9c6e85
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 15, 2026 11:10
c9c6e85 to
9f39d9b
Compare
…nfig_presentation off dump() get_config_presentation was the last native-path consumer of dump() (it used dump() only as a privacy registry to redact Private params from the startup-log / config-diff presentation). Rework it to take an injected private-path set: get_config_presentation<T: Serialize>(config, include_private_parameters, private_paths) — dropping the SerializeConfig bound. Callers (load_and_validate_config startup log, config_manager diff) inject &private_parameters() (the committed config_secrets_schema.json set). The injected set equals the old dump()-derived Private set exactly (is_private() == privacy==Private), so redaction is preserved with no leak / no over-redaction; a new no-leak test guards it. remove_path_from_json (the redaction mechanism) is retained. This unblocks deleting dump()/SerializeConfig in Phase 9. apollo_config 27+4, apollo_config_manager 15, apollo_node_config 33, apollo_deployments 8 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
nimrod-starkware
force-pushed
the
nimrod/jsonnet/delete-config-pointers
branch
from
July 15, 2026 11:26
3a820fb to
bf6cdb3
Compare
nimrod-starkware
force-pushed
the
nimrod/jsonnet/presentation-off-dump
branch
from
July 15, 2026 11:26
9f39d9b to
a1eee5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

get_config_presentation was the last native-path consumer of dump() (it used dump() only
as a privacy registry to redact Private params from the startup-log / config-diff
presentation). Rework it to take an injected private-path set:
get_config_presentation<T: Serialize>(config, include_private_parameters, private_paths)
— dropping the SerializeConfig bound. Callers (load_and_validate_config startup log,
config_manager diff) inject &private_parameters() (the committed config_secrets_schema.json
set). The injected set equals the old dump()-derived Private set exactly (is_private() ==
privacy==Private), so redaction is preserved with no leak / no over-redaction; a new
no-leak test guards it. remove_path_from_json (the redaction mechanism) is retained.
This unblocks deleting dump()/SerializeConfig in Phase 9. apollo_config 27+4,
apollo_config_manager 15, apollo_node_config 33, apollo_deployments 8 green.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com