apollo_deployments,deployment: set storage-reader-server ports as constants

[nimrod-starkware]

The three storage-reader-server ports (batcher 55011, class_manager 55210,
state_sync 55014) are fixed infra constants, not per-deployment overrides. Bake
them into the app_configs and applicative_config jsonnet instead of templatizing
them as $$$...$$$ placeholders, and restrict the generic port/url
auto-templatizing in replace_pred to components.* keys only. Add
state_sync_config...network_config.port to KEYS_TO_BE_REPLACED to preserve its
existing overridability. Drop the now-redundant storage-reader port overrides
from the common and testing overlay YAMLs.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• deployment: add native node-config builder and wire it into the ConfigMap #14609 : 2 dependent PRs (#14655 , #14674 )
• deployment: thread config_format from CLI to node container arg #14608
• apollo_deployments,deployment: set storage-reader-server ports as constants #14607 👈 (View in Graphite)
• apollo_node: add new CLI arg to parse config #14606
• apollo_deployments: check applicative config matches deployed app_configs #14489 : 2 other dependent PRs (#14480 , #14505 )
• apollo_deployments: assemble and deserialize node config from jsonnet #14487
• apollo_deployments: assemble full node config via build.libsonnet #14486
• apollo_deployments: distributed layout jsonnet test #14485
• apollo_deployments: consolidated layout jsonnet test #14484
• apollo_deployments: test hybrid layout for infra config #14483
• apollo_deployments: introduce hybrid layout for infra config #14482
• apollo_deployments: introduce jsonnet building blocks for infra config #14481
• apollo_deployments: jsonnet applicative config #14479
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion.

---

crates/apollo_deployments/src/service.rs line 369 at r1 (raw file):

    // auto-templatized — an overridable one must be listed explicitly in `KEYS_TO_BE_REPLACED`;
    // the rest (e.g. the fixed storage-reader-server ports) keep their literal app_config
    // value.

shrink comment

Code quote:

    // Only `components.*` infra fields are auto-templatized: the layout assigns each component's
    // remote URL and port per deployment. Ports/URLs OUTSIDE `components.*` are NOT
    // auto-templatized — an overridable one must be listed explicitly in `KEYS_TO_BE_REPLACED`;
    // the rest (e.g. the fixed storage-reader-server ports) keep their literal app_config
    // value.

[nimrod-starkware]

@nimrod-starkware resolved 1 discussion.
Reviewable status: 0 of 10 files reviewed, all discussions resolved.

[nimrod-starkware]

@nimrod-starkware made 1 comment.
Reviewable status: 0 of 10 files reviewed, 1 unresolved discussion.

---

crates/apollo_deployments/src/service.rs line 103 at r2 (raw file):

    "state_sync_config.static_config.central_sync_client_config.sync_config.store_sierras_and_casms_block_threshold",
    "state_sync_config.static_config.network_config.#is_none",
    "state_sync_config.static_config.network_config.port",

is this needed?

Code quote:

 "state_sync_config.static_config.network_config.port"

[cursor]

PR Summary

Medium Risk
Wrong listener ports would break storage-reader connectivity; narrowing replace_pred changes which config keys become deployment placeholders.

Overview
Treats batcher (55011), class_manager (55210), and state_sync (55014) storage-reader-server ports as fixed infra constants instead of per-deployment replacer placeholders.

Those values are set in applicative jsonnet and static/replacer app_configs (replacing shared 8091 / $$$_..._$$$ entries). Hybrid overlay sequencerConfig lines that only repeated those ports are removed; Kubernetes service.ports for the storage-reader listeners are unchanged.

replace_pred in service.rs now auto-templatizes only components.* .port / .url keys (plus KEYS_TO_BE_REPLACED). state_sync_config.static_config.network_config.port is added to KEYS_TO_BE_REPLACED so P2P network port stays explicitly overridable like before.

^{Reviewed by Cursor Bugbot for commit 5747cee. Bugbot is set up for automated code reviews on this repo. Configure here.}

[nimrod-starkware]

@nimrod-starkware resolved 1 discussion.
Reviewable status: 0 of 13 files reviewed, all discussions resolved (waiting on dan-starkware and matanl-starkware).