Skip to content

feat(app-builder): regenerate canonical Todo showcase - #130

Merged
kattsushi merged 1 commit into
feat/app-builder-golden-generate-commandfrom
feat/app-builder-golden-showcase
Aug 14, 2026
Merged

feat(app-builder): regenerate canonical Todo showcase#130
kattsushi merged 1 commit into
feat/app-builder-golden-generate-commandfrom
feat/app-builder-golden-showcase

Conversation

@kattsushi

@kattsushi kattsushi commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Closes #127
Part of #131

Summary

  • Regenerates the canonical Todo showcase from the current PR feat(app-builder): expose public generate command #129 head through the installed public effectify-app-builder generate --events=jsonl command.
  • Commits and verifies the exact 18-output standalone workspace, including immutable provenance, zero-write replay, and installed-public drift detection.
  • Updates CI, root discovery exclusions, acceptance evidence, and authority tests for the canonical showcase contract.

PR Type

  • Bug fix
  • New feature
  • Documentation only
  • Code refactoring
  • Maintenance/tooling
  • Breaking change

Chain Context

Canonical Generation Proof

  • The eligibility gate accepted all six Unit 1 through Unit 6 evidence identities and returned { "prNumber": 130, "status": "eligible" } against the frozen PR feat(app-builder): regenerate canonical Todo showcase #130 authority.
  • Generation packed the contracts, generation, and CLI packages, installed them through an isolated registry, and invoked only the installed public CLI binary.
  • The generated workspace contains exactly four Nx projects: @effectify/todo-domain, @effectify/todo-application, @effectify/todo-infrastructure, and @effectify/todo-cli.
  • All four generated projects passed build, typecheck, and test. The runtime scenario emitted add, complete, and remove events and ended with an empty Todo state.
  • The replay wrote zero paths and preserved all 18 byte and mode identities.
  • Cleanup stopped the Nx daemon, released the registry port, and removed the isolated store and workspace.
  • tools/check-app-builder-showcase.mjs reproduces the installed-public generation path and checks every output path, digest, mode, and zero-write replay.

19 → 18 Migration

  • Replaces the previous 19-output fixture with the canonical 18-output installed-public result.
  • Removes six obsolete per-output .effectify/generation receipts.
  • Adds the five canonical workspace root files: nx.json, package.json, pnpm-workspace.yaml, tsconfig.build.json, and vitest.config.mts.
  • Uses workspace package-name imports and dependency manifests instead of cross-project relative source imports.

Changes

File / area Change
examples/app-builder-todo/** Canonical 18-output Todo workspace, provenance receipt, and regeneration guide
tools/check-app-builder-showcase.mjs Installed-public regeneration, identity comparison, replay, and cleanup drift authority
packages/app-builder/cli/tests/showcase.test.ts Freezes all 18 identities and proves root workspace exclusions
.github/workflows/ci.yml Adds the recurring installed-public showcase drift job
.nxignore, .oxfmtrc.json, nx.json, pnpm-workspace.yaml Keeps the standalone fixture out of root discovery and formatter mutation
openspec/changes/app-builder-golden-monorepo/tasks.md Records completion of the approved showcase acceptance work

Size Exception

The maintainer explicitly approved size:exception for this atomic regeneration unit.

Classification Files Additions Deletions Policy treatment
Canonical generated goldens 18 387 0 Excluded from authored budget
Fixture provenance and README 2 195 0 Authored
CI, drift checker, tests, config, and acceptance evidence 8 330 5 Authored
Policy-authored total 10 525 5 530 changed lines, approved exception
Full candidate 28 912 5 917 changed lines total

The independent validation passed every technical identity, gate, generation, runtime, drift, format, sync, lockfile, and state-integrity check. Its prior FAIL verdict was solely the then-unapproved 530-line authored budget. The explicit maintainer exception resolves that publication blocker.

Test Plan

  • Eligibility gate returned eligible with complete Unit 1 through Unit 6 evidence.
  • Installed-public generation produced exactly 18 outputs and the exact four-project graph.
  • Generated workspace build, typecheck, test, and runtime scenario passed.
  • Zero-write replay preserved every generated byte and mode.
  • Installed-public drift checker passed all 18 identities; deliberate drift exited 1 without rewriting the fixture.
  • Affected App Builder build, typecheck, test, and lint validation passed; tests covered 275 cases.
  • Installed-public E2E passed 4 of 4 lifecycle scenarios.
  • Format, Nx sync, frozen lockfile, full candidate diff, and cleanup checks passed.
  • No shell scripts changed; ShellCheck is not applicable.

Regenerated Identity

  • Frozen previous PR feat(app-builder): regenerate canonical Todo showcase #130 head: d5928f99a122b04cb70ff68bfa02fa2d5648a5fc.
  • Regenerated base: 85cc877ab8ed960f84a174304b0e12c7477878c6.
  • Regenerated commit: d6a26b807b4801dabcb9bd29829affa65c9bb2ff.
  • Candidate tree: 200981243c41405aaf6c95c7b2dd88ec436f71a7.
  • Full-index binary diff SHA-256: 1e3dd84154ccc99201b26cf754cfc68469f354114649dd8718fb2b1449dbbc45.

Rollback

If regeneration must be reverted, restore the frozen head only while the regenerated head is still current:

git push origin d5928f99a122b04cb70ff68bfa02fa2d5648a5fc:refs/heads/feat/app-builder-golden-showcase \
  --force-with-lease=feat/app-builder-golden-showcase:d6a26b807b4801dabcb9bd29829affa65c9bb2ff

Contributor Checklist

  • Linked approved issue Deliver App Builder Golden showcase and closure slice #127 and retained Part of #131 context.
  • Retained exactly one type:feature label.
  • Recorded the approved size:exception and complete generated/authored breakdown.
  • Included the installed-public generator, runtime, replay, drift, and cleanup evidence.
  • Used a Conventional Commit message.
  • Included no Co-Authored-By or AI attribution.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 35663959-9d92-4bd6-be87-d0a0053662fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kattsushi
kattsushi force-pushed the feat/app-builder-golden-showcase branch from d5928f9 to d6a26b8 Compare August 14, 2026 17:44
@kattsushi kattsushi changed the title feat(app-builder): add canonical Todo showcase feat(app-builder): regenerate canonical Todo showcase Aug 14, 2026
@kattsushi
kattsushi marked this pull request as ready for review August 14, 2026 17:52
@kattsushi
kattsushi merged commit 414681e into feat/app-builder-golden-generate-command Aug 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant