test(app-builder): prove CLI lifecycle cleanup - #149
Merged
kattsushi merged 3 commits intoAug 14, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kattsushi
marked this pull request as ready for review
August 13, 2026 23:49
24 tasks
kattsushi
merged commit Aug 14, 2026
fa88569
into
feat/app-builder-public-cli-success-proof
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
Part of #131. Depends on #147 Unit 6A.
PR Type
type:chore)Summary
Changes
ProcessTimeoutError.Test plan
CI=true NX_DAEMON=false pnpm nx run-many --target=build --projects=@effectify/app-builder-contracts,@effectify/app-builder-generation,@effectify/app-builder-cli,@effectify/app-builder-nx-plugin --parallel=1 --outputStyle=static --skipNxCache --skipRemoteCache: PASS, all four dependency builds succeeded uncached.CI=true NX_DAEMON=false pnpm nx run-many --target=typecheck --projects=@effectify/app-builder-contracts,@effectify/app-builder-generation,@effectify/app-builder-cli,@effectify/app-builder-nx-plugin --parallel=1 --outputStyle=static --skipNxCache --skipRemoteCache: PASS, all four dependency typechecks and required builds succeeded uncached.CI=true NX_DAEMON=false pnpm nx run-many --target=test --projects=@effectify/app-builder-contracts,@effectify/app-builder-generation,@effectify/app-builder-cli,@effectify/app-builder-nx-plugin --parallel=1 --outputStyle=static --skipNxCache --skipRemoteCache: PASS, contracts 67 tests, generation 29 tests, CLI 9 tests, and Nx plugin 9 tests.CI=true NX_DAEMON=false pnpm nx run-many --target=lint --projects=@effectify/app-builder-contracts,@effectify/app-builder-generation,@effectify/app-builder-cli,@effectify/app-builder-nx-plugin --parallel=1 --outputStyle=static --skipNxCache --skipRemoteCache: PASS, 0 errors; contracts retained 6 pre-existing warnings and the other projects had 0 warnings.CI=true NX_DAEMON=false pnpm nx run-many --targets=build,typecheck,lint,test --projects=@effectify/app-builder-e2e --parallel=1 --outputStyle=static --skipNxCache --skipRemoteCache: PASS, all targets succeeded uncached and the focused E2E matrix passed 1 file / 4 tests.CI=true NX_DAEMON=false pnpm nx run @effectify/repo:format:check --outputStyle=static --skipNxCache --skipRemoteCache: PASS, exactly the 2 changed files are correctly formatted.CI=true NX_DAEMON=false pnpm nx sync:check: PASS, the workspace is up to date with no sync generators.git diff --check dc97f7a09effc1159cc3bcdc92801723a2b78112andgit diff --exit-code -- pnpm-lock.yaml: PASS, no whitespace errors and no lockfile change.@acme/admin-console:typecheckfailed with TS2322, cleanup completed, and Node reachedbeforeExit/exit at 58,411 ms with a 0 ms tail.ProcessTimeoutErrorfor the configured 50 ms timeout, reachedbeforeExit/exit at 79 ms, and retained no Timeout resource.3496af17e4ca93702971e6b6509feb60d4a2483d, binary diff SHA-256dedb740466ac02d7ee66985dfcc6dd188b7bb7fb900c90dede91f397ac4e5321, report SHA-256bf51edcd8ae29226d2930b1663802a80d70644919c43abb7d0e5603cdc1b1f5c, and correction evidence SHA-256792cfe82429e8c8d14ef6fe981590546b13a17ca5505023625474f6f94a22f0b.Contributor checklist
type:*label,type:chore.test(app-builder): prove CLI lifecycle cleanup.Co-Authored-Bytrailers.Chain Context
feat/app-builder-public-cli-success-proofatdc97f7a09effc1159cc3bcdc92801723a2b78112Chain Overview
Scope
dc97f7a09effc1159cc3bcdc92801723a2b78112and ends at one Unit 6B commit containing exactly two mode-100644 E2E files.feat/app-builder-public-cli-success-proof; Unit 7 follows only after this slice.Rollback boundary
Revert the single Unit 6B commit to restore exactly
packages/app-builder/e2e/src/golden-workspace.tsandpackages/app-builder/e2e/tests/golden.e2e.test.tsto Unit 6A atdc97f7a09effc1159cc3bcdc92801723a2b78112. This removes only the negative lifecycle proof without touching #147, Unit 7, or frozen PR #130.Autonomy