feat(app-builder): gate showcase regeneration - #151
Merged
kattsushi merged 1 commit intoAug 14, 2026
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kattsushi
marked this pull request as ready for review
August 14, 2026 14:04
kattsushi
merged commit Aug 14, 2026
32d1562
into
feat/app-builder-public-cli-negative-lifecycle-proof
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150
Part of #131. Depends on #149 Unit 6B.
PR Type
type:feature)Summary
Pr130RegenerationBlockedfailures with deterministic ordered reasons for missing, duplicate, mismatched, or stale proofd5928f99a122b04cb70ff68bfa02fa2d5648a5fcas typed input evidence onlyChanges
packages/app-builder/generation/src/index.tspackages/app-builder/generation/src/regeneration.tspackages/app-builder/generation/tests/regeneration.test.tsValidation status
Functional, purity, and exact candidate identity checks passed. The final independent validation did not return PASS. Publication proceeds only with the maintainer-accepted residual validation risk disclosed below.
Test plan
NX_DAEMON=false pnpm nx run @effectify/app-builder-generation:build --skip-nx-cache: PASS, generation and contracts compiled successfully.NX_DAEMON=false pnpm nx run @effectify/app-builder-generation:typecheck --skip-nx-cache: PASS.NX_DAEMON=false pnpm nx run @effectify/app-builder-generation:test --skip-nx-cache: PASS, 9 files and 36 tests.NX_DAEMON=false pnpm nx run @effectify/app-builder-generation:lint --skip-nx-cache: PASS, 0 warnings and 0 errors across 36 files.NX_DAEMON=false pnpm nx run @effectify/app-builder-cli:test --skip-nx-cache: PASS, 1 file and 9 tests.NX_DAEMON=false pnpm nx run @effectify/app-builder-e2e:test --skip-nx-cache: PASS, 1 file and 4 public E2E tests.pnpm exec oxfmt --check packages/app-builder/generation/src/index.ts packages/app-builder/generation/src/regeneration.ts packages/app-builder/generation/tests/regeneration.test.ts: PASS, check-only.NX_DAEMON=false pnpm nx sync:check: PASS, workspace up to date with no sync generators.git diff --checkplus temporary-indexgit diff --cached --check: PASS.8f029c956efc4dfc6cc7e1a586bd972e9d29939f, full-index binary diff SHA-25660d9fd344b65a556ec0537a51898f72689370450a00e7120b38c7cc6e4e6cf36, 251 additions, 0 deletions, and exactly three mode-100644 paths./tmp/effectify-unit7-final-validation.jsonhas SHA-256f17a6726e63dc79e332955f11f406a1fa1a73243a108083cd074172de6d4aec0and records the accepted residual findings below.Accepted residual risk
The maintainer explicitly selected
Aceptar riesgo residualand authorized draft publication with transparent disclosure:Pr130RegenerationBlockedwith the exactMissingEvidencereason.literalsandmembers) remains runtime mutable. No eligibility bypass was reproduced because the gate uses its private frozen authority./tmpreports were missing after session interruption, so their JSON and hashes could not be re-verified and evidence lineage remains incomplete. They were not recreated or fabricated.This acceptance authorizes publication of the exact candidate. It does not convert the final independent report into a PASS.
Contributor checklist
Part of #131.type:*label,type:feature.feat(app-builder): gate showcase regeneration.Co-Authored-Byor attribution trailers.Chain Context
feat/app-builder-public-cli-negative-lifecycle-proofat54b9677b541cdb4fb3f0be11d5b4e77914f8a4c7Chain Overview
Scope
54b9677b541cdb4fb3f0be11d5b4e77914f8a4c7and ends at one Unit 7 commit containing exactly three mode-100644 paths.Non-goals
Rollback boundary
Revert commit
7d3493c5352fe81fb4a72277978f398af7ec50cbto remove onlypackages/app-builder/generation/src/index.ts,packages/app-builder/generation/src/regeneration.ts, andpackages/app-builder/generation/tests/regeneration.test.tschanges from Unit 7. This does not touch #149, #131, or frozen #130.Autonomy