feat(app-builder): prove installed CLI generation - #147
Merged
kattsushi merged 5 commits intoAug 14, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kattsushi
marked this pull request as ready for review
August 13, 2026 17:38
This was referenced Aug 13, 2026
kattsushi
merged commit Aug 14, 2026
8cfeaa0
into
feat/app-builder-v1-parity-migration
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #146
Part of #131. Depends on #143 and its independently reviewed correction merged as #145.
PR Type
type:feature)Summary
node_modules/.bin/effectify-app-builderJSONL CLI@acmeOperations, Task, and AdminConsole naming against the exact four-project generated Nx graphChanges
effectify-app-builderbinary with stdin JSONL generation events.@acme/admin-consoleplus the Operations application, domain, and infrastructure projects.Test plan
pnpm nx run-many --projects @effectify/app-builder-contracts --targets build,typecheck,test,lint --nxBail --skip-nx-cache: PASS, 24 files / 67 tests; build, typecheck, and lint passed; 6 existing lint warnings and 0 errors.pnpm nx run-many --projects @effectify/app-builder-generation --targets build,typecheck,test,lint --nxBail --skip-nx-cache: PASS, 8 files / 29 tests; build, typecheck, and lint passed.pnpm nx run @effectify/app-builder-nx-plugin:{build,typecheck,test,lint} --skip-nx-cacheas four sequential invocations: PASS, 1 file / 9 tests; all targets passed.pnpm nx run @effectify/app-builder-cli:{build,typecheck,test,lint} --skip-nx-cacheas four sequential invocations: PASS, 1 file / 9 tests; all targets passed.pnpm nx run @effectify/app-builder-e2e:{typecheck,build,lint} --skip-nx-cacheas sequential invocations: PASS, all targets passed.pnpm nx run @effectify/app-builder-e2e:test --skip-nx-cache: PASS, dependent public builds plus 1 file / 1 test; 27.0s Nx run and 24.32s Vitest.pnpm exec oxfmt --check <eight changed paths>: PASS, all matched files correctly formatted; 7 recognized files because.templateis not a formatter input.git diff --check: PASS.30a43782fbbd316e9eb54635a4334841aa8fe660, binary diff SHA-25668740e732bfb7432cdb56933e980b9cbf9325623e0fe6e669fdc2a1e23067cf1, with no process, workspace, root graph, index, or lockfile leak.Contributor checklist
type:*label,type:feature.feat(app-builder): prove installed CLI generation.Co-Authored-Bytrailers.Chain Context
feat/app-builder-v1-parity-migrationat2ad43e0cca44a0ed34db27fa29b344a71fc8e214Chain Overview
Scope
2ad43e0cca44a0ed34db27fa29b344a71fc8e214and ends at the single Unit 6A commit containing exactly eight validated paths.Rollback boundary
Revert the single Unit 6A commit to restore exactly the eight changed paths to
2ad43e0cca44a0ed34db27fa29b344a71fc8e214. This removes only the public installed-CLI success proof and exact-four-project Nx correction, without touching #143/#145, Unit 6B, Unit 7, or PR #130.Autonomy