Skip to content

feat(app-builder): preserve Todo v1 parity - #143

Merged
kattsushi merged 14 commits into
feat/app-builder-public-atomic-materializationfrom
feat/app-builder-v1-parity-migration
Aug 14, 2026
Merged

feat(app-builder): preserve Todo v1 parity#143
kattsushi merged 14 commits into
feat/app-builder-public-atomic-materializationfrom
feat/app-builder-v1-parity-migration

Conversation

@kattsushi

@kattsushi kattsushi commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Closes #142

Part of #131. Depends on #141. Includes the independently reviewed architectural correction from #145.

Summary

  • preserve the independent frozen Todo v1 output contract through atomic generation
  • retain compatibility APIs while migrating default ownership to the atomic path
  • fail closed on parity, replay, duplicate-path, or surface-ownership drift
  • carry forward the declarative-template/generalized-kernel correction reviewed independently in PR refactor(app-builder): use declarative generation templates #145 and merged into this branch

Changes

Area Change
Atomic generation Add the Todo v1 atomic compatibility composition and exports.
Compatibility Route the existing preset through the parity-preserving owner migration.
Frozen contract Add an independent Todo v1 fixture and exact output assertions.
Architecture Incorporate the declarative-template/generalized-kernel correction from PR #145.
Tests Cover default behavior, owner migration, parity drift, and replay compatibility.

Test plan

  • Generation tests — 30/30
  • CLI tests — 9/9
  • Nx tests — 8/8
  • Relevant generation, CLI, and Nx typechecks
  • Formatting and diff check
  • Read-only validator
  • Runtime evidence — ordinal/generation 17; sha256:4effd6796f5c25b1227fac670b6a648651aa46a01e956da2d13686b19c001e2c
  • RDD/review disabled and unmanaged; receipts not applicable

Contributor checklist

  • Linked an approved issue
  • Added exactly one type:* label
  • Tests included with the behavior
  • Conventional commit format
  • No Co-Authored-By trailers

Chain Context

Field Value
Chain App Builder reusable generation kernel
Tracker issue #131
Position Unit 5, with the merged PR #145 architectural correction
Base feat/app-builder-public-atomic-materialization at 21b92cc56
Current head 2ad43e0cca44a0ed34db27fa29b344a71fc8e214
Accumulated diff 2,195 changed lines (1,692 additions, 503 deletions) across 73 files
Depends on #141 and #145
Follow-up Issue #131 Unit 6 public CLI/Nx/E2E proof, then Unit 7 PR #130 eligibility gate
Review boundary Maintainer-approved separate slices: review #143 original parity migration scope and PR #145 independently, not as one 2,195-line review
Starts at Public atomic Todo materialization from #141
Ends with Frozen Todo v1 parity, default compatibility, fail-closed atomic owner migration, and the merged declarative-template/generalized-kernel correction

Chain Overview

#133
 └── #135
      └── #137
           └── #139
                └── #141
                     └── 📍 #143 Unit 5 parity migration
                          ├── #145 architectural correction (independently reviewed, merged)
                          └── Issue #131 Unit 6: public CLI/Nx/E2E proof
                               └── Unit 7: #130 eligibility gate

Review Slices

  • PR feat(app-builder): preserve Todo v1 parity #143 original slice: frozen Todo v1 parity, compatibility exports/defaults, atomic owner migration, and focused tests.
  • PR refactor(app-builder): use declarative generation templates #145: declarative-template/generalized-kernel architectural correction, independently bounded at 1,994 changed lines, reviewed with all checks passing, and merged into this branch via merge commit 2ad43e0cca44a0ed34db27fa29b344a71fc8e214.
  • Maintainer decision: treat these as separately reviewed slices. Do not re-review them as one 2,195-line accumulated diff.

Scope

Dependencies

Next Steps

  1. Complete issue Deliver reusable App Builder generation kernel #131 Unit 6 public CLI/Nx/E2E proof.
  2. Run Unit 7 as the PR feat(app-builder): regenerate canonical Todo showcase #130 eligibility gate.
  3. Keep PR feat(app-builder): regenerate canonical Todo showcase #130 frozen until both gates pass.

Rollback boundary

Revert commit 731cbc165 to remove the original Unit 5 files/edits and restore the #141 public atomic materialization state. PR #145 is a separately reviewed architectural correction merged afterward and must be handled as its own rollback slice. Neither rollback slice includes PR #130, Unit 6, or audit-only commits.

Autonomy

@kattsushi kattsushi added the type:feature New feature work label Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2ebf61d9-f8cf-4f75-9dd3-d62c67fd2056

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kattsushi
kattsushi marked this pull request as ready for review August 12, 2026 01:52
@kattsushi
kattsushi merged commit 5ac25f7 into feat/app-builder-public-atomic-materialization Aug 14, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature New feature work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant