Skip to content

feat(sync): select relay fallback before committing a sync path - #2494

Merged
kunickiaj merged 1 commit into
mainfrom
feat/relay-path-selection
Nov 4, 2026
Merged

kunickiaj merged 1 commit into
mainfrom
feat/relay-path-selection

Conversation

@kunickiaj

@kunickiaj kunickiaj commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Description

Keep healthy direct connections preferred and allow encrypted relay fallback after a direct probe fails. Serialize passes for each peer, apply caller deadlines, and record one final attempt. After direct status commits, preserve legacy per-request timeouts and prevent path switching or replay after possibly applied work.

Record send success and unique operation receipts only after a validated channel POST acknowledgment. Record failed sends separately so receive success is preserved.

Successful relay passes refresh peer last-sync and last-seen timestamps and clear the previous error without changing stored address fields.

Direct status, pull, and push requests retain configured URL path prefixes when reachability is enabled.

Type of Change

  • 🚀 Feature (new functionality)

Testing

  • Relevant checks pass locally: root typechecks, Biome, and 126 selector/pass tests and 39 actual channel tests, including receive-error recovery and acknowledged-send diagnostics.
  • Added/updated tests for changes

Checklist

  • Code follows project style
  • Self-review completed
  • No new warnings introduced

@kunickiaj kunickiaj changed the title feat(sync): complete encrypted relay sync and readiness feat(sync): select relay fallback before committing a sync path Nov 3, 2026
@kunickiaj
kunickiaj marked this pull request as ready for review November 3, 2026 22:00
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T00:14:26.631726Z bf94453 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 91b151f017

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch from 1932453 to ad4d4bc Compare November 3, 2026 22:25
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch 2 times, most recently from 2c6df10 to f21f927 Compare November 3, 2026 22:33
@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch from ad4d4bc to a2cde87 Compare November 3, 2026 22:33
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from f21f927 to 20f56d9 Compare November 3, 2026 22:45
@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch from a2cde87 to 6d83516 Compare November 3, 2026 22:45

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20f56d9471

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch from 6d83516 to 22f78a7 Compare November 3, 2026 22:51
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch 2 times, most recently from f515116 to a2c3a91 Compare November 3, 2026 23:18
@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch 2 times, most recently from 532a331 to cab588e Compare November 3, 2026 23:39
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from a2c3a91 to 2fdfd70 Compare November 3, 2026 23:39
@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch from cab588e to 99f1175 Compare November 3, 2026 23:42
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from 2fdfd70 to a956a62 Compare November 3, 2026 23:42
@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch from 99f1175 to bb2f8f6 Compare November 3, 2026 23:57
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from a956a62 to 710cac4 Compare November 3, 2026 23:57
@kunickiaj
kunickiaj force-pushed the test/relay-encrypted-client branch 2 times, most recently from 5c76b58 to 572e35b Compare November 4, 2026 00:07
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from 710cac4 to 29f3c10 Compare November 4, 2026 00:07
@kunickiaj
kunickiaj changed the base branch from test/relay-encrypted-client to graphite-base/2494 November 4, 2026 00:12
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from 29f3c10 to 1874382 Compare November 4, 2026 00:12
@graphite-app
graphite-app Bot changed the base branch from graphite-base/2494 to main November 4, 2026 00:12
@kunickiaj
kunickiaj force-pushed the feat/relay-path-selection branch from 1874382 to bf94453 Compare November 4, 2026 00:12
@kunickiaj
kunickiaj merged commit ac0c097 into main Nov 4, 2026
18 checks passed

Copy link
Copy Markdown
Owner Author

Merge activity

@kunickiaj
kunickiaj deleted the feat/relay-path-selection branch November 4, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant