Repository navigation
Conversation
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 17, 2026 08:13
This was referenced Oct 17, 2026
This was referenced Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HostedCart changed-scope regression shared one 30-second test budget across seven CLI invocations and timed out on Windows.
Run reformatting and added-derived-state scenarios as separate parameterized tests. Each gets a fresh temporary repository, Git baseline and saved report, and performs four real CLI invocations. These two scenarios now perform eight invocations combined. Preserve both baseline-rule checks and every rule/count/exit-status/line assertion across Git changed-scope, saved-baseline changed-scope and saved-baseline full-scan comparisons. Production behavior and the existing per-test timeout are unchanged.
Validation on the existing head: all 25 affected-module tests and all 2,715 CLI-family tests passed (24 skipped); all 10 typecheck tasks, lint, format, build and built JSON-report smoke passed. No code correction or additional commit was needed. Test-only change; no changeset, fuzz or diagnostic parity run.
Integration order: land #2076 after the timeout-bearing siblings, especially #2075 and the shared 49. Preserve these isolated
it.eachrows when resolving overlap so the old seven-scan loop is not reintroduced. Retain a scoped timeout allowance only as appropriate; no older ready branches or bases are changed by this PR.