Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 18, 2026 01:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Native Node path strings can contain RegExp metacharacters. This adds a finite check for an unescaped native path used as leading literal text in a RegExp pattern.
What changed
path.resolvenamespace calls, supportedfs.realpathSynccomposition, exact separator normalization, and at most two readonly result bindings. Keep existing rule routes and unsupported provider, transport, selector, and wrapper boundaries.Test plan
8201239e9b: 305 focused tests passed. All seven local checks passed, including 34,279 tests with 1,118 skips, typecheck, lint, formatting, registry generation, a forced serial build, and JSON report smoke. Lint retained two classified warnings in synthetic fixtures and none in changed production files. The unused fixture binding is cleaned up separately in FPFNFIXAPEX mark an unused native-path fixture binding #2111; the deliberate constant-reassignment control remains.The sample does not establish full-corpus parity, target activation in every sampled project, or a performance improvement. Synthetic API/CLI scans do not execute application or provider code. This validation leaves the PR's existing readiness unchanged.