Skip to content

fix: consolidate reviewed false-positive detector fixes - #2254

Open
aidenybai wants to merge 5 commits into
mainfrom
codex/mega-fp-20261025
Open

aidenybai wants to merge 5 commits into
mainfrom
codex/mega-fp-20261025

Conversation

@aidenybai

@aidenybai aidenybai commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Why

Combine 131 reviewed false-positive fixes and 34 shared fixes and prerequisites into one validated candidate. Supported APIs, aliases, state flows, and cleanup patterns avoid incorrect warnings while unsafe-case controls remain active.

What changed

  • Integrate the 165 frozen source heads listed below, retaining their patch changesets.
  • Repair combined-rule defects, Windows fixture paths, wide-callback traversal, comment-aware JSX checks, and canonical SDK ownership proofs.
  • Share webhook parsing across SDK and entrypoint proofs, including parser failures, provider mutation, and cross-file changes.
  • Preserve exact Unicode ID values and split ID references only at HTML ASCII whitespace, fixing false duplicates and missed references from FPFNFIXAPEX preserve Unicode ID identity in duplicate-reference checks #2255. Add regression tests and a minimal fuzz corpus case.
  • Repair large-diff workflow arguments and allow Windows CI 30 minutes for unit and packed CLI checks.

Eval results

Current head: ddbfae53d82dd12b8344122734ce5ec756c67684, based on 84ad0c8d0df7a3ab7d26946367fae3bc39c100d0.

Check Result
Fresh candidate coverage 2,000 pinned projects; zero failures or skipped records
Diagnostics versus preceding validated aggregate 1,184,660 → 1,184,660
Added / removed versus preceding aggregate 0 / 0
Semantic comparison Exact match across all 2,000 project coverages and 560 rule/invariant buckets; diagnostic content and duplicate multiplicity preserved
Reviewed main delta carried unchanged 6,308 added / 8,085 removed
Evidence tmp/p2254-ddbfae53d82d-v1; independent closure b79fb4e6…; complete reports and lossless archives retained

The fresh full scan matched the preceding b4d063e28d3fc59456dfa6b0d4b6cffd49dc876d report exactly. Its bridge to ready parent 12454c0603771404982d328a63f721d60c4f8881 changes only the Windows CI budget, with all other source and 169 built artifacts verified identical. The accepted main delta carries from that original main-84 comparison; this is not a new direct comparison against the separately cached baseline. Both official builders ran with strict candidate validation over the complete emitted-rule union, including automatic TypeScript and invariant coverage.

Stock parity covers the configured lint rules with dead-code and supply-chain passes disabled. Current-head performance evidence comes from fresh paired local profiles against ready parent 12454c0603771404982d328a63f721d60c4f8881.

Test plan

  • All 27 local validation commands: 44,427 tests passed with 1,119 existing skips; seven typechecks, five fresh builds, lint, formatting, generated-output checks, JSON-report smoke validation, and dependency checks. The focused Unicode suite also passed all 19 cases.
  • Fresh strict changed-rule fuzzing: 2,206 programs executed, 33 diagnostic activations, zero findings or advisories.
  • Three public CLI workloads across cold, hot, and no-cache cohorts: 90 measured runs, 18 warmups, and 18 dedicated CPU-profile runs. All nine cohorts passed the unchanged regression gates; the largest median increase was 21.1 ms (2.9%). CPU captures, peak RSS, complete diagnostic multisets, and lossless archives were independently reviewed. Both profile revisions used Node 26.5.1; functional suites used Node 22.
  • Normal signed commit and nonforce push passed stock hooks and preserved every validated source file and all 169 built artifacts.
  • Full 2,000-project report validation, producer/corpus binding, exact semantic comparison, and independent evidence review passed. All owned evaluator resources and process groups closed.
  • Exact-head CI is green across all configured platforms and Node versions; mergeability is clean and no review threads remain unresolved.

The mixed-HTML-entity control retains a preexisting false negative on both parent and head: one diagnostic expected, zero observed. Entity decoding needs a separate fix; this mismatch is retained in the evidence and excluded from passing semantic-control claims.

Included source PRs and frozen heads (165)
Source Placement Frozen head
#1944 COMMON 4b4fbd3f5ebf825b99025df80e1ca6009181c305
#1945 COMMON 7b6a8e406fac053a3b0a821f8ffa91781187379f
#1946 FP 50cfc1040ce918297e98903fd19b61173b04aeca
#1947 FP d3f21d3a82dfdabb26ecff810de6fd39b547b13e
#1949 FP 59f489bc5fbba1a7a459018c7273b3ee37ee7ad9
#1950 FP 45b38cedcbf488cb634ec068be7903e5b3303cd6
#1955 FP f3e3afd152a4f12b2ab9ca38267b6a3900aa4a21
#1958 COMMON 3251494c27f1704767d0f47ddbee67f2511063d5
#1959 FP b8bc379cdd10373d5b41c2453c4bd8b7d9672e4a
#1968 FP 42e1a4d4e6395e70a6bbf3c1f5c28d099d5b8133
#1970 COMMON fab43a3ac7fc9935493a2f95837fa53de1217096
#1971 FP 2f134f922e90544aaf05fc5e1a7f2ff8a4f03dcc
#1973 FP 57bdcb85b53d1252af2f80e22e797caa7f4464d0
#1974 FP 9d89c6e68b6deef767615240727cb762b324d0ac
#1975 FP 15bad2fe32d4dcfc03c4864321a2b9efde546b8d
#1976 FP 1dd10d747679d25eaeb542449722181f3c005e8d
#1977 FP c0aba570c98fb5a98e5c6f3aa26a8f8ab0d0b512
#1984 FP 7454163064fda7d0c69aa0a98c6906fc147cd79b
#1987 FP 645641fb2442f438c03050c5efd8fb7a563725e3
#1988 FP 3016bfdcf7628f697fd3b73cca2cf573328f45fc
#1990 FP 30180b30cfcab2a52c5c7b21670c9d8469ed3242
#1991 FP dac142f3f6f6d113f2daeb0ef16887713e021ec5
#1992 COMMON 1f7953c59095b1a43bbc0b0ca2a5854ac0eda690
#1993 FP e4588603923fa5c6a2cbbee9f6658bd5928b8bee
#1994 COMMON 898e6d3c6496f94a83b22f0956ce40419a950197
#1995 FP f126f8ffdab9c693ae5130231c773a763d80156d
#1996 FP dff288cb48ea6473c3e8d61e80565144ae9c909f
#1997 FP 50b572d776754cb098c1f2548ea2a8e9b8bd3e65
#1998 FP 5fbc32411d6a69767cee15032e8129c853573c17
#1999 FP f8507661b8efaccb5206dda81e8f00388a85ae08
#2001 COMMON 4d6a7ed6bb2e743c711fd2ea20df5036a0c3a94e
#2002 COMMON f677dbe4e00907c4904ea1e3069e56089b219ed0
#2003 COMMON 8fccdb1a5bd7bc6c87551e06e2a767e2c73f29f1
#2005 FP 762395d651d539a142bf36ea6f5a1741f5418e2f
#2006 FP 98eaa5563b73ab7d071b542279336e98a7ce5630
#2007 FP fd7d8bd9e282c1fde08262dbe9ea69a452144460
#2009 FP 92e286464afd164c22588ea88cc785a14605c2a9
#2014 FP d8a683d38f607a0a4435cb145d932400191326c9
#2015 FP a6b5d9c4fef0f62a4edca6fd9f4e9cda0e099f06
#2016 COMMON cfc7c4b1bba2996d72ebaaee8f7fae004f2a419a
#2021 FP a8bf948ab7d65380e425d301f5a748f048f7386f
#2022 FP 67e7eb9d5080c2e6fae201389fd6f50167f77e3b
#2023 FP d9ce8c53056c903b53747d3d68e245b55dfec0c9
#2024 FP ec919c9c9b75cc5edbe156c4e13498936daec62a
#2025 FP ddc4c740c886b71a6cdb591008862a798b44d181
#2026 COMMON 130ab17161402cbb9277b0f5fa144b86ecb6442a
#2027 FP 2cb95c3a61e83f9dcbe3363e6a8dd1bc4a4e9fb0
#2029 FP 302f9ccf252cd9f275ec34fe7b7954e1d673b8fc
#2030 FP e4d2f2bc474bbfb6d6adbbecff7f3bf2c565ecb5
#2031 COMMON 9d7880c2b25d953bdb79591f8349fc23fcfb5233
#2032 FP aa3af69f71614338aa65359444866e18580f4e9c
#2033 FP 9cc5906d1f6b3817dcf5fa73a6a6bb14e54345c3
#2034 FP 29ae8796349a5a7acedecf7dccb113dca60b0a89
#2035 COMMON 31e39a5d115169f00e79e6683384c22d7aac68c0
#2036 FP 626e3668753cec43210d47c826cc2a6a7236496e
#2037 FP 65e74fd5639a14f73ac13cebecda59a769c1d1d0
#2038 FP cafe5359a165bbc7770ca583aaa58e8a049098af
#2040 FP 895aa95805791e09c53ace9e03df58bb4ef997c8
#2042 COMMON a9f8766fe394bbb40969d8b806523fd4fe7618c8
#2044 FP 31396486138f0b0095193faa325cf2d86a4a06f4
#2045 FP ac4c727c44f4fc1b9a76498741f16529d473839b
#2046 FP 1282add61ea6bca91bd9b3347cdc9eea528956fa
#2047 FP 85c9cf5e9546a835ecff96cf6ae84b3bc1c28b57
#2048 FP 0bb1746d7a19186cee9dc3702c4348e1bd90dfcf
#2049 FP 663d985ffd85a7db24278b37091277ee8c053294
#2053 COMMON 638b705bed85b41ad30392cec1f2a92c3783cdaf
#2055 COMMON cb70dcca42c238811447935d1112d0730c3f4d18
#2056 COMMON 11d2a8d86c424e01281e22e30915f3afa1484cda
#2057 FP 3b813bf651818dd51998e1946bae08051c1ef095
#2058 FP 99b91753b2409cdb9d3fd89117c48af349f5fe54
#2061 FP 81d4d3a744551065682e19f128bada9266859bb4
#2062 FP 3fefa215653e535ba6eef9b7844753031454e3a9
#2064 FP fd96b5471f728b3ddc60115f64accb5eae7b6462
#2065 FP 395ff758307b66236fda1f7e52b514d3a7bd5694
#2066 FP 8ba87f1ade000403a5cc367c0124e469994e32c8
#2067 FP 3568942832204e974aff9159fb674d7298bb0703
#2068 FP 45cda5df010e6df66599a2b913408c5488f03606
#2069 FP 4f059e60a9c67597c56d5fe486d962595685b413
#2071 FP 33f35c4ef34cd33145f56b2e4a53a09467481e11
#2072 COMMON e799ac8f0ca492a5dce0612946f2d7cfdaa0ba6b
#2074 FP 90c0f0c5f3a4eb815020dd5bdf9257135eeb67e9
#2075 FP e71c63f4e53e6b5b913ea99a445fba2b9a9c0ef3
#2076 COMMON 09f19e19134ab00541f58fc027ce9a3a1d5ac142
#2078 FP 13afb2ab0467f75aa50f8cb6f97c7d2d7a93b69a
#2079 COMMON 15bd306c832158c89810b62cb48a6168e6f5fcd2
#2080 FP 7389a9a4cee7449ddce9b7d6af91c01c45292768
#2081 FP ee32909e5c75086e788bf47721d1dd977cc71f76
#2083 FP c477831d428c8649afbf26cd87b5f468f242bac6
#2084 FP b471363006e6dcdf7a67cccbf1e9cb060b319c83
#2085 COMMON 92154a1d98bb5c3ca1299460245141714d64ceec
#2086 FP cbfe7824118040e6491d25f4c74ec529acc2e21c
#2088 FP 45dde76ede2ce471fc1f44dacb4fbb1fa057c4da
#2090 FP b767f63ca6766cfac46036bd0e6f7db36b861e7c
#2091 FP 1cf031823e1212cb72e4a2932229a1a55d8a2790
#2093 FP 38797acc1897e0c3cf674d3e05f2812c860a93dc
#2094 FP 805d2d1935bfd46cc42b240bac4fa3a5c7302dbf
#2095 FP 86b8ccc1233d5797264fe454040520d19f39b5e7
#2096 FP fc973b00e8f790c575464cb0c35cee690c90be2f
#2098 FP 57b23233cde47edd25064ec88f3de15c106d6821
#2099 FP df9333704e8b9cdf813c00e7ad22d54cb1897a80
#2100 FP ab7d5f8e036a96d59629b665b872663fb0a4d566
#2101 FP dc0d7ddc5aa05492ca71f6a2da8335781d80617e
#2102 FP 65ce092c0ae7d7633ba27e941e6f928966a9a7a6
#2103 FP 7dbd4ddfb4b134b594ec540da5f82654c921a8c8
#2104 FP 7be86c3ae8757c66fbae794203078eada5018106
#2105 FP ce314d558216dce64ff32455fa1708143719bf40
#2107 FP 25e5930c75cc43562ba465e9a2798e832da59fc8
#2109 FP e102cf215e1b44653b69ca67c77d46bb48581c39
#2110 FP 5db34b9cca8cfe958802cf2d8f57135deb202fe9
#2112 FP 2aaeb0f4bd303a0a59e1a93774532f4870f4e6ea
#2113 FP 65efacb6824f834023668a2d66bd73f1fe6ccb41
#2114 FP 998f22a2058dd0dbff0b5056578c63dfefd9f3d4
#2115 FP 9f0ad83b390614f674ad746c987babbcf29943bb
#2116 FP d26dbb0895c2fcfb6504d2b6551158b6d807396e
#2117 COMMON 62ed51327c9b5e33e543bd72b531a3372cddc75d
#2118 FP 1f84ce1bb906832d95ac442dbaaa79b43724635d
#2119 FP 610fc9141a9761c052be83309d4ae615ece0eb32
#2121 FP 7bbf4dd36ac32206057b64ea7b1ba05f62a6bc60
#2123 FP 2c536668cb5f639924e246cc939656f3af6682eb
#2124 FP 044afb5ad07321e087a9b1c108d610010c9a69bc
#2125 FP e7a927e034be66d768de06a48a9c01aa92eeedeb
#2126 FP 6f9bc42943d710151f84fa717055d44d17de90c7
#2127 COMMON 4e739b8edccbe2091977ab7530a1c321b3ae2d1d
#2128 FP 35b8281513e5d0dd454f3b1a215999be579e6b45
#2134 COMMON 41cc16a764e1a0736829d30c8decc8f83cd60a7f
#2135 COMMON 256d8bcc92cf42e395f1bd3164cf52185161c626
#2137 FP c00492109ad3b50af75af99f7e05428883160a99
#2139 FP 71226bea128172de870727e1214e5a6cd58b7c45
#2140 FP 867196ac85a1db5609d2a0ba3368fbdb010ea638
#2141 FP a0081e68b8b465c8dd5c240552c7e5c599d0f916
#2144 COMMON e701f397a7dab9367497006026414f6919ad4f41
#2150 FP ba501d4e40cd9761144ef904da780e4f5af0e43f
#2151 FP 1f75f7965988fcd87aa2879fa27bf67bbb9a1779
#2152 FP ca6b091db4d377cc4bde17242d422385e20c41a1
#2154 FP f1d6503130561338d87539f7888abbf2217239e6
#2155 FP 481756905debb6ce24bc1766ff141146ec7603e8
#2156 FP d8621c5182c9669caf780ebf8a8353dbf2f3add7
#2157 FP 711cc04863f43d70b47e1eba7177ec056eba7003
#2158 FP 1045b8559fffbc2021313f26addffac5d3ab34e8
#2159 FP 5e699abe6be8edf35749f91803304f7839a2a8df
#2160 FP 826a23fb65ca502c47ebc77d2944b639cab681b3
#2162 FP 9b846055ee7733e3329b3d74970a3ae36fcc5fa6
#2163 FP 055cc0d12f7b734b9513c67f0ea05971aa685e86
#2164 FP 276e36a8697d53f2ad2c8e1bf46ae3eb9fe6ee2f
#2165 FP 6d49e74fa030021b0824097154f086b7c45c042c
#2166 COMMON b6048235d39ce8b7ed58885bf2fac377251bcc67
#2167 COMMON 8fb68f815f786262eb570c09727e380dfbe6fbb4
#2168 FP 2412b2c3314ffbd4b5b1594eff215ceb29358c86
#2171 COMMON 04ff55b9163f399ba43454c0ad3df397c67ef634
#2172 FP 4750f007c693613029e92c07c21070ee4e9f6bb5
#2173 FP a75ca825f2e368f50910b25019c2e8d0dd43438a
#2174 FP f17935a8f1064236d0bd2271ffdf383a31f37fe6
#2175 FP 1bdba500f99b2feda42afbdc1337757068480489
#2176 FP c68b7001125f82d23e44929231b73050976b5889
#2177 COMMON adcd927bf16bc8d0c48b873ca7162a43e531cf9d
#2178 COMMON e3428ee8863acd3e3519f818b9ecddb9d3ee5105
#2181 FP 6fcbae237aad28fc891a7343cc3a9fe21bd1c9c2
#2182 FP 146ddd195715d1b48c8e24a2fb34bf55d48aa834
#2183 FP 7d7d3f47c4d812a5fe28b0d407a4f1a8b114a699
#2184 FP 6e083da705f024fe0af670bcc18001288ed0622d
#2185 FP a6ace00e6e96322fbffd42dc965218ba3d3c31b3
#2187 COMMON dbf4cf51b19b35c94e33e96c9231fe5b70075bfa
#2189 COMMON 96ebb5a554784884336c120c04db3d75a7d153f9
#2190 FP 2d11cfdc677fab4e503a5118fd7e30b7a71975df
#2255 COMMON 25c9b6fa26f05ef159e5d7b2f7a11b20952bb053

@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-react-doctor@2254
npm i https://pkg.pr.new/oxlint-plugin-react-doctor@2254
npm i https://pkg.pr.new/react-doctor@2254

commit: ddbfae5

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

React Doctor found no new issues. 🎉

Reviewed by React Doctor for commit ddbfae5.

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Interactive terminal E2E

Terminal Control verified the built CLI at ddbfae5 in a real PTY:

  • selected a project interactively and observed Scanning... before the three-second Git delay completed
  • waited for the clean result and exercised the compact report
  • opened copy context and the GitHub Actions confirmation, then cancelled safely

Download the edited MP4 and PNG evidence

@aidenybai
aidenybai marked this pull request as ready for review October 28, 2026 10:40
Preserve literal ID values and split references at HTML ASCII whitespace so
Unicode whitespace cannot create false duplicates or hide actual references.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants