Repository navigation
Conversation
commit: |
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
aidenybai
marked this pull request as ready for review
October 28, 2026 10:40
Preserve literal ID values and split references at HTML ASCII whitespace so Unicode whitespace cannot create false duplicates or hide actual references.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Combine 131 reviewed false-positive fixes and 34 shared fixes and prerequisites into one validated candidate. Supported APIs, aliases, state flows, and cleanup patterns avoid incorrect warnings while unsafe-case controls remain active.
What changed
Eval results
Current head:
ddbfae53d82dd12b8344122734ce5ec756c67684, based on84ad0c8d0df7a3ab7d26946367fae3bc39c100d0.tmp/p2254-ddbfae53d82d-v1; independent closureb79fb4e6…; complete reports and lossless archives retainedThe fresh full scan matched the preceding
b4d063e28d3fc59456dfa6b0d4b6cffd49dc876dreport exactly. Its bridge to ready parent12454c0603771404982d328a63f721d60c4f8881changes only the Windows CI budget, with all other source and 169 built artifacts verified identical. The accepted main delta carries from that original main-84 comparison; this is not a new direct comparison against the separately cached baseline. Both official builders ran with strict candidate validation over the complete emitted-rule union, including automatic TypeScript and invariant coverage.Stock parity covers the configured lint rules with dead-code and supply-chain passes disabled. Current-head performance evidence comes from fresh paired local profiles against ready parent
12454c0603771404982d328a63f721d60c4f8881.Test plan
The mixed-HTML-entity control retains a preexisting false negative on both parent and head: one diagnostic expected, zero observed. Entity decoding needs a separate fix; this mismatch is retained in the evidence and excluded from passing semantic-control claims.
Included source PRs and frozen heads (165)
4b4fbd3f5ebf825b99025df80e1ca6009181c3057b6a8e406fac053a3b0a821f8ffa91781187379f50cfc1040ce918297e98903fd19b61173b04aecad3f21d3a82dfdabb26ecff810de6fd39b547b13e59f489bc5fbba1a7a459018c7273b3ee37ee7ad945b38cedcbf488cb634ec068be7903e5b3303cd6f3e3afd152a4f12b2ab9ca38267b6a3900aa4a213251494c27f1704767d0f47ddbee67f2511063d5b8bc379cdd10373d5b41c2453c4bd8b7d9672e4a42e1a4d4e6395e70a6bbf3c1f5c28d099d5b8133fab43a3ac7fc9935493a2f95837fa53de12170962f134f922e90544aaf05fc5e1a7f2ff8a4f03dcc57bdcb85b53d1252af2f80e22e797caa7f4464d09d89c6e68b6deef767615240727cb762b324d0ac15bad2fe32d4dcfc03c4864321a2b9efde546b8d1dd10d747679d25eaeb542449722181f3c005e8dc0aba570c98fb5a98e5c6f3aa26a8f8ab0d0b5127454163064fda7d0c69aa0a98c6906fc147cd79b645641fb2442f438c03050c5efd8fb7a563725e33016bfdcf7628f697fd3b73cca2cf573328f45fc30180b30cfcab2a52c5c7b21670c9d8469ed3242dac142f3f6f6d113f2daeb0ef16887713e021ec51f7953c59095b1a43bbc0b0ca2a5854ac0eda690e4588603923fa5c6a2cbbee9f6658bd5928b8bee898e6d3c6496f94a83b22f0956ce40419a950197f126f8ffdab9c693ae5130231c773a763d80156ddff288cb48ea6473c3e8d61e80565144ae9c909f50b572d776754cb098c1f2548ea2a8e9b8bd3e655fbc32411d6a69767cee15032e8129c853573c17f8507661b8efaccb5206dda81e8f00388a85ae084d6a7ed6bb2e743c711fd2ea20df5036a0c3a94ef677dbe4e00907c4904ea1e3069e56089b219ed08fccdb1a5bd7bc6c87551e06e2a767e2c73f29f1762395d651d539a142bf36ea6f5a1741f5418e2f98eaa5563b73ab7d071b542279336e98a7ce5630fd7d8bd9e282c1fde08262dbe9ea69a45214446092e286464afd164c22588ea88cc785a14605c2a9d8a683d38f607a0a4435cb145d932400191326c9a6b5d9c4fef0f62a4edca6fd9f4e9cda0e099f06cfc7c4b1bba2996d72ebaaee8f7fae004f2a419aa8bf948ab7d65380e425d301f5a748f048f7386f67e7eb9d5080c2e6fae201389fd6f50167f77e3bd9ce8c53056c903b53747d3d68e245b55dfec0c9ec919c9c9b75cc5edbe156c4e13498936daec62addc4c740c886b71a6cdb591008862a798b44d181130ab17161402cbb9277b0f5fa144b86ecb6442a2cb95c3a61e83f9dcbe3363e6a8dd1bc4a4e9fb0302f9ccf252cd9f275ec34fe7b7954e1d673b8fce4d2f2bc474bbfb6d6adbbecff7f3bf2c565ecb59d7880c2b25d953bdb79591f8349fc23fcfb5233aa3af69f71614338aa65359444866e18580f4e9c9cc5906d1f6b3817dcf5fa73a6a6bb14e54345c329ae8796349a5a7acedecf7dccb113dca60b0a8931e39a5d115169f00e79e6683384c22d7aac68c0626e3668753cec43210d47c826cc2a6a7236496e65e74fd5639a14f73ac13cebecda59a769c1d1d0cafe5359a165bbc7770ca583aaa58e8a049098af895aa95805791e09c53ace9e03df58bb4ef997c8a9f8766fe394bbb40969d8b806523fd4fe7618c831396486138f0b0095193faa325cf2d86a4a06f4ac4c727c44f4fc1b9a76498741f16529d473839b1282add61ea6bca91bd9b3347cdc9eea528956fa85c9cf5e9546a835ecff96cf6ae84b3bc1c28b570bb1746d7a19186cee9dc3702c4348e1bd90dfcf663d985ffd85a7db24278b37091277ee8c053294638b705bed85b41ad30392cec1f2a92c3783cdafcb70dcca42c238811447935d1112d0730c3f4d1811d2a8d86c424e01281e22e30915f3afa1484cda3b813bf651818dd51998e1946bae08051c1ef09599b91753b2409cdb9d3fd89117c48af349f5fe5481d4d3a744551065682e19f128bada9266859bb43fefa215653e535ba6eef9b7844753031454e3a9fd96b5471f728b3ddc60115f64accb5eae7b6462395ff758307b66236fda1f7e52b514d3a7bd56948ba87f1ade000403a5cc367c0124e469994e32c83568942832204e974aff9159fb674d7298bb070345cda5df010e6df66599a2b913408c5488f036064f059e60a9c67597c56d5fe486d962595685b41333f35c4ef34cd33145f56b2e4a53a09467481e11e799ac8f0ca492a5dce0612946f2d7cfdaa0ba6b90c0f0c5f3a4eb815020dd5bdf9257135eeb67e9e71c63f4e53e6b5b913ea99a445fba2b9a9c0ef309f19e19134ab00541f58fc027ce9a3a1d5ac14213afb2ab0467f75aa50f8cb6f97c7d2d7a93b69a15bd306c832158c89810b62cb48a6168e6f5fcd27389a9a4cee7449ddce9b7d6af91c01c45292768ee32909e5c75086e788bf47721d1dd977cc71f76c477831d428c8649afbf26cd87b5f468f242bac6b471363006e6dcdf7a67cccbf1e9cb060b319c8392154a1d98bb5c3ca1299460245141714d64ceeccbfe7824118040e6491d25f4c74ec529acc2e21c45dde76ede2ce471fc1f44dacb4fbb1fa057c4dab767f63ca6766cfac46036bd0e6f7db36b861e7c1cf031823e1212cb72e4a2932229a1a55d8a279038797acc1897e0c3cf674d3e05f2812c860a93dc805d2d1935bfd46cc42b240bac4fa3a5c7302dbf86b8ccc1233d5797264fe454040520d19f39b5e7fc973b00e8f790c575464cb0c35cee690c90be2f57b23233cde47edd25064ec88f3de15c106d6821df9333704e8b9cdf813c00e7ad22d54cb1897a80ab7d5f8e036a96d59629b665b872663fb0a4d566dc0d7ddc5aa05492ca71f6a2da8335781d80617e65ce092c0ae7d7633ba27e941e6f928966a9a7a67dbd4ddfb4b134b594ec540da5f82654c921a8c87be86c3ae8757c66fbae794203078eada5018106ce314d558216dce64ff32455fa1708143719bf4025e5930c75cc43562ba465e9a2798e832da59fc8e102cf215e1b44653b69ca67c77d46bb48581c395db34b9cca8cfe958802cf2d8f57135deb202fe92aaeb0f4bd303a0a59e1a93774532f4870f4e6ea65efacb6824f834023668a2d66bd73f1fe6ccb41998f22a2058dd0dbff0b5056578c63dfefd9f3d49f0ad83b390614f674ad746c987babbcf29943bbd26dbb0895c2fcfb6504d2b6551158b6d807396e62ed51327c9b5e33e543bd72b531a3372cddc75d1f84ce1bb906832d95ac442dbaaa79b43724635d610fc9141a9761c052be83309d4ae615ece0eb327bbf4dd36ac32206057b64ea7b1ba05f62a6bc602c536668cb5f639924e246cc939656f3af6682eb044afb5ad07321e087a9b1c108d610010c9a69bce7a927e034be66d768de06a48a9c01aa92eeedeb6f9bc42943d710151f84fa717055d44d17de90c74e739b8edccbe2091977ab7530a1c321b3ae2d1d35b8281513e5d0dd454f3b1a215999be579e6b4541cc16a764e1a0736829d30c8decc8f83cd60a7f256d8bcc92cf42e395f1bd3164cf52185161c626c00492109ad3b50af75af99f7e05428883160a9971226bea128172de870727e1214e5a6cd58b7c45867196ac85a1db5609d2a0ba3368fbdb010ea638a0081e68b8b465c8dd5c240552c7e5c599d0f916e701f397a7dab9367497006026414f6919ad4f41ba501d4e40cd9761144ef904da780e4f5af0e43f1f75f7965988fcd87aa2879fa27bf67bbb9a1779ca6b091db4d377cc4bde17242d422385e20c41a1f1d6503130561338d87539f7888abbf2217239e6481756905debb6ce24bc1766ff141146ec7603e8d8621c5182c9669caf780ebf8a8353dbf2f3add7711cc04863f43d70b47e1eba7177ec056eba70031045b8559fffbc2021313f26addffac5d3ab34e85e699abe6be8edf35749f91803304f7839a2a8df826a23fb65ca502c47ebc77d2944b639cab681b39b846055ee7733e3329b3d74970a3ae36fcc5fa6055cc0d12f7b734b9513c67f0ea05971aa685e86276e36a8697d53f2ad2c8e1bf46ae3eb9fe6ee2f6d49e74fa030021b0824097154f086b7c45c042cb6048235d39ce8b7ed58885bf2fac377251bcc678fb68f815f786262eb570c09727e380dfbe6fbb42412b2c3314ffbd4b5b1594eff215ceb29358c8604ff55b9163f399ba43454c0ad3df397c67ef6344750f007c693613029e92c07c21070ee4e9f6bb5a75ca825f2e368f50910b25019c2e8d0dd43438af17935a8f1064236d0bd2271ffdf383a31f37fe61bdba500f99b2feda42afbdc1337757068480489c68b7001125f82d23e44929231b73050976b5889adcd927bf16bc8d0c48b873ca7162a43e531cf9de3428ee8863acd3e3519f818b9ecddb9d3ee51056fcbae237aad28fc891a7343cc3a9fe21bd1c9c2146ddd195715d1b48c8e24a2fb34bf55d48aa8347d7d3f47c4d812a5fe28b0d407a4f1a8b114a6996e083da705f024fe0af670bcc18001288ed0622da6ace00e6e96322fbffd42dc965218ba3d3c31b3dbf4cf51b19b35c94e33e96c9231fe5b70075bfa96ebb5a554784884336c120c04db3d75a7d153f92d11cfdc677fab4e503a5118fd7e30b7a71975df25c9b6fa26f05ef159e5d7b2f7a11b20952bb053