Repository navigation
Conversation
commit: |
Contributor
Interactive terminal E2ETerminal Control verified the built CLI at
|
Contributor
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
aidenybai
marked this pull request as ready for review
October 17, 2026 13:40
6 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A synchronous updater can copy an ordinary primitive array with
previous.slice(), change one element on that fresh local copy, and return it without an external side effect. The bounded exception retains warnings when the copy/state escapes, the element or index is not proven primitive, or provider integrity is unsupported.What changed
Validation
The authored ambient-eval control is rejected by the native parser (
Cannot assign to eval in strict mode); it is reported as a parser exclusion, not preserved detector behavior. The other 49 authored controls preserve their complete target-rule native diagnostics and locations. The 26 valid review controls have 15 intentional target changes: three false positives removed, eight visible provider-loader hazards and four primitive binding writes restored as warnings. Independent ownership/work controls also preserve complete native diagnostics.The actual API/CLI comparison uses 75 valid synthetic files under both default and explicitly enabled target profiles. Native arrays and ordinary imported producer modules remain explicit trust boundaries. This is bounded synthetic validation, not an exhaustive-state or full-corpus parity claim. ECMAScript's slice algorithm uses species construction and property reads; constructor/prototype/reflection hazards therefore remain outside the admitted profile.
Fresh full sandbox parity could not run: this revision's run-parity skill requires Vercel token/OIDC plus team/org and project credentials, which are absent. The original Daytona credential is also absent.
Integration
Read-only overlap checks against the current updater siblings #1967, #1969 and #1972 preserve each detector change and this exemption, pairwise and together. Shared canonical files and changeset are byte-identical. No new merge-order dependency is implied; validate the eventual integrated branch.
The final Windows run exposed the existing HostedCart seven-scan integration test exceeding its 30-second allowance. This PR includes only the previously reviewed scoped 60-second test allowance, preserving all seven scans/assertions and all reviewed runtime hashes. The new tree passed fresh uncached 12-task tests/all 10 typechecks and all focused, lint/format/registry, strict 500 fuzz, native/API/CLI, build and JSON-smoke checks. Its two-file normal hook uses the validated local CLI without downloading a published fallback. This overlaps the timeout-bearing siblings: when combining with #2076, preserve its isolated scenarios rather than restoring the old seven-scan loop.