refactor(app-builder): use declarative generation templates - #145
Merged
kattsushi merged 5 commits intoAug 13, 2026
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kattsushi
marked this pull request as ready for review
August 12, 2026 14:26
kattsushi
merged commit Aug 13, 2026
2ad43e0
into
feat/app-builder-v1-parity-migration
10 checks passed
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #144
Summary
generateFiles; no custom template parser or language subset is maintained.@nx/devkit.generateFilesstaging authoritative for selected template output, including partial-evolution non-template files.Changes
packages/app-builder/generation/src/templates/assets/**packages/app-builder/generation/src/templates.tspackages/app-builder/generation/src/generators/**packages/app-builder/nx-plugin/src/apply-plan.tsgenerateFilesand atomically commits generated bytes to the caller Tree.Task/@acmematerialization, filename substitution, partial staging authority, generated-byte precedence, CLI/Nx parity, rollback, and frozen v1 compatibility.Test Plan
pnpm format:checkgit diff --check 66bfa635fContributor Checklist
type:*label (type:chore; the repository has notype:refactor).Review Context
size:exception: one consolidated correction PR, maximum 2,000 changed lines..templateremains canonical because Nx strips only that terminal suffix;.ejswould leak into generated filenames.formatFilesis intentionally not called: committed templates define exact shared bytes, including the frozen Todo v1 digest fixture, and adapter-side formatting would introduce a second output authority.