Repository navigation
TS SDK: declare task dependencies by calling tasks - #73435
Merged
jason810496 merged 1 commit intoSep 23, 2026
Merged
jason810496 merged 1 commit into
jason810496 merged 1 commit into
Conversation
This was referenced Sep 21, 2026
jason810496
force-pushed
the
feature/ts-sdk/native-dag-authoring-syntax
branch
from
September 22, 2026 09:33
e7ead8a to
9be8f51
Compare
1 task done
jason810496
force-pushed
the
feature/ts-sdk/native-dag-authoring-syntax
branch
2 times, most recently
from
September 22, 2026 11:42
a17d0fa to
1c0a934
Compare
jason810496
marked this pull request as ready for review
September 22, 2026 11:52
pierrejeambrun
approved these changes
Sep 22, 2026
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Overall LGMT.
Just one nit.
jason810496
force-pushed
the
feature/ts-sdk/native-dag-authoring-syntax
branch
from
September 22, 2026 13:10
1c0a934 to
508da6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ts-sdk/adr/0002-native-dag-interface.mddecides that the call graph is the task graph:dag.task(...)hands back a factory, and calling it places the task and supplies its arguments. Before this, wiring travelled in aninputsoption nothing read.How
dag.task(taskId, handler)returns aTaskFactory. Calling it records the task's place and its inputs; each argument takes an upstream reference or a literal JSON value.load(transformed=transform(...)).TaskRefexists only once its producing call has returned, which is what makes a cycle through arguments unwritable.TaskRefcarries its handler's return type, so a construct that needs a particular one can ask for it.Bundlekeeps the Dags declared in TypeScript and the task handlers for Python-declared Dags in separate maps, since onedag_idbelongs to one of them and never both.Was generative AI tooling used to co-author this PR?