Repository navigation
TS SDK: add task groups to the native Dag surface - #73439
Merged
pierrejeambrun merged 1 commit intoSep 30, 2026
Merged
Conversation
This was referenced Sep 21, 2026
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
5 times, most recently
from
September 23, 2026 02:46
2e1afbe to
0b33a18
Compare
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
5 times, most recently
from
September 27, 2026 13:50
4166797 to
4f61e31
Compare
1 task done
jason810496
marked this pull request as ready for review
September 29, 2026 08:01
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
from
September 29, 2026 12:13
4f61e31 to
12244c5
Compare
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
from
September 29, 2026 12:58
12244c5 to
45ea18a
Compare
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Two small nits, overall looking good.
jason810496
marked this pull request as draft
September 30, 2026 01:40
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
from
September 30, 2026 02:27
45ea18a to
87f2734
Compare
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
from
September 30, 2026 02:31
87f2734 to
159e4da
Compare
jason810496
marked this pull request as ready for review
September 30, 2026 02:38
jason810496
commented
Sep 30, 2026
jason810496
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for the review.
This was referenced Sep 30, 2026
jason810496
force-pushed
the
feature/ts-sdk/task-groups
branch
from
September 30, 2026 05:12
159e4da to
0490d68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS SDK: add task groups to the native Dag surface
mainon its own.Why
ts-sdk/adr/0002decision 5 keeps Python's grouping semantics: a scope offering the sametaskandtaskGroupmethods as the Dag, prefixing each task id, and standing at either end of an edge asgroup1 >> group2does.How
dag.taskGroup(groupId, options?)opens that scope and prefixes the id of everything declared in it, asprefix_group_iddoes.{ prefixGroupId: false }keeps the ids as written.validate_group_keydoes: at most 200 characters, letters, digits, dashes and underscores only.Nodeis the base type both a task and a group satisfy, sobeforeandaftertake either. Python has the same inDAGNode; the Go SDK calls itairflow.Node.What
TaskGroupRef,TaskGroupOptions,Node, andTaskGroupRecordas what the Dag records.Was generative AI tooling used to co-author this PR?