Repository navigation
TS SDK: draw order-only edges with before and after - #73438
Merged
jason810496 merged 1 commit intoSep 30, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:DAG-processing
area:dev-tools
area:ts-sdk
kind:documentation
labels
This was referenced Sep 21, 2026
jason810496
force-pushed
the
feature/ts-sdk/order-only-edges
branch
5 times, most recently
from
September 23, 2026 02:46
a4271ae to
3a8a791
Compare
jason810496
requested review from
guan404ming and
pierrejeambrun
and removed request for
guan404ming
September 23, 2026 02:52
jason810496
marked this pull request as ready for review
September 23, 2026 02:52
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
LGTM. A few suggestions
jason810496
force-pushed
the
feature/ts-sdk/order-only-edges
branch
2 times, most recently
from
September 24, 2026 05:25
16380b8 to
f06e54e
Compare
1 task done
pierrejeambrun
approved these changes
Sep 24, 2026
pierrejeambrun
left a comment
pierrejeambrun
left a comment
Member
There was a problem hiding this comment.
Thanks. LGTM.
Self loop detection added and general loop detection follow up PR is in draft.
jason810496
force-pushed
the
feature/ts-sdk/order-only-edges
branch
2 times, most recently
from
September 27, 2026 13:50
909171b to
bc4cde1
Compare
1 task done
jason810496
force-pushed
the
feature/ts-sdk/order-only-edges
branch
2 times, most recently
from
September 29, 2026 12:58
5a6fcf3 to
1eafee5
Compare
jason810496
force-pushed
the
feature/ts-sdk/order-only-edges
branch
from
September 29, 2026 15:50
1eafee5 to
946f545
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An edge that carries no value has no argument to travel as, so a task call cannot express it.
ts-sdk/adr/0002decision 4 draws it between the references instead — the TypeScript pair for Python's>>and<<.How
loaded.before(cleaned)andcleaned.after(loaded, transformed), both taking any number of references, so one call draws several edges.Was generative AI tooling used to co-author this PR?