Mark notifications with the source qube's colour - #19
Conversation
fafdb68 to
ea60c06
Compare
|
I like it, @marmarta what do you think? |
|
PipelineRetry |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026082719-devel&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests10 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 37 fixed
Unstable testsDetails
Performance TestsPerformance degradation:20 performance degradations
Remaining performance tests:91 tests
|
|
I generally like it, but I have questions: how does it look when the icon has some transparency? I wonder if this remains readable with colorful icons - I don't see that many colorful icons in notifications in general, though. |
|
It doesn't appear to work :( For the size, either the limit should be higher, or the client should scale it down to allowed size. The current limit seems to be 255, so almost... Maybe dbus notification spec includes suggested limits? As for the |
It shouldn't have any problems with transparency. I tested it, for example, with this:
I haven't tested it with qubes, just directly on Debian. Let me try to address these problems. |
|
Suggestion: If you intend for this pull request to resolve the associated issue and would like for it to be linked to the issue automatically, you can put |
Read and decode the named PNG inside the qube and forward it as ordinary image-data, so only pixels ever cross the Qube boundary.
ea60c06 to
4f2ed18
Compare
Thank you changed. |
|
nm-applet now looks to work: https://openqa.qubes-os.org/tests/194312#step/startup/8 (click the image icon to see colors) :) |
5 participants
This is what I got:
Closes QubesOS/qubes-issues#9648