Revert "Cleanup disposable on failed startup" - #879
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #879 +/- ##
=======================================
Coverage 70.70% 70.70%
=======================================
Files 61 61
Lines 14315 14315
=======================================
Hits 10121 10121
Misses 4194 4194
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Aug 26, 2026
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026082616-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 30 fixed
Unstable testsDetails
Performance TestsPerformance degradation:18 performance degradations
Remaining performance tests:93 tests
|
This was referenced Aug 26, 2026
Member
Author
This is about the re-introduced bug that was fixed by the reverted commit. Will need to live with that for now. |
This introduces an issue with named disposables being removed - worse than the original issue. Proper fix turned out to be more complicated, so revert offending commit for now. This reverts commit a82f4f2. Fixes QubesOS/qubes-issues#11042
marmarek
force-pushed
the
dispvm-cleanup-hotfix
branch
from
August 27, 2026 00:30
9fde4df to
d4eaffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces an issue with named disposables being removed - worse
than the original issue. Proper fix turned out to be more complicated,
so revert offending commit for now.
This reverts commit a82f4f2.