Report swapinfo - #140
Open
ben-grande wants to merge 1 commit into
Open
Conversation
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jun 25, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
=======================================
Coverage 71.24% 71.24%
=======================================
Files 6 6
Lines 991 991
=======================================
Hits 706 706
Misses 285 285 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jun 25, 2026
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 3, 2026
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 6, 2026
marmarek
requested changes
Jul 10, 2026
Comment on lines
+89
to
+90
| sprintf(used_mem_buf, "%lld", used_mem); | ||
| sprintf(used_swap_buf, "%lld", used_swap); |
| syslog(LOG_DAEMON | LOG_ERR, "error writing meminfo to xenstore ?"); | ||
| exit(1); | ||
| } | ||
| if (!xs_write(xs, XBT_NULL, "memory/swapinfo", swap, strlen(swap))) { |
Member
There was a problem hiding this comment.
Note to self: this can be merged only after core-admin part, which sets necessary xenstore access.
| char *swap; | ||
| } UsedMem; | ||
|
|
||
| UsedMem parse(const char *meminfo_buf, const char* dom_current_buf) |
Member
There was a problem hiding this comment.
FWIW the usual method in C for returning more results is to either return a pointer to a structure (usually dynamically allocated via malloc), or add output parameters (pointers to where function should write result). In case of a simple structure like this, compiler will do the latter for you here, so it can stay this way, but keep in mind it wont be efficient code in more complex cases.
ben-grande
commented
Jul 13, 2026
| return (UsedMem){ .mem = used_mem_buf, .swap = used_swap_buf }; | ||
| } | ||
| return NULL; | ||
| return (UsedMem){ .mem = NULL, .swap = NULL }; |
Author
There was a problem hiding this comment.
Report swap change if above threshold despite memory being below its threshold.
| if (meminfo_data) | ||
| send_to_qmemman(xs, meminfo_data); | ||
| UsedMem meminfo_data = parse(meminfo_buf, dom_current_buf); | ||
| if (meminfo_data.mem && meminfo_data.mem[0]) |
Author
There was a problem hiding this comment.
Allows distinguishing how much memory the qube is using from what is assigned by using "meminfo - swapinfo". For: QubesOS/qubes-core-admin#827
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 14, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" being used in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 14, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" being used in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 16, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" being used in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 17, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 17, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 21, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 22, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 22, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 22, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 22, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 22, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 23, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 23, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 24, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 24, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 30, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Jul 31, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Aug 1, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Aug 2, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Aug 3, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
ben-grande
added a commit
to ben-grande/qubes-core-admin
that referenced
this pull request
Aug 6, 2026
Although both values can be lied by the qube, we can distinguish the "memory types" in client tools. For: QubesOS/qubes-linux-utils#140
marmarek
added a commit
to QubesOS/qubes-core-admin
that referenced
this pull request
Aug 6, 2026
* origin/pr/827: Avoid reads to xenstore keys that are not written Deprecate cpu_usage_raw from Stats event Report more CPU information to QubesHost Report maxmem and fix get_mem variants Hotplug memory for real Skip stubdom_xid query if qube is not HVM Do not require Xen to get VM stats Report amount of swap used Broadcast memory correctly Report vcpu in stats API Pull request description: - online vcpus - time of each vcpu - share all vm_info captured with clients (I presume there is no intent to capture private information internally and not broadcast to clients, as the only place where `get_vm_stats()` is called is from `admin.vm.Stats`. --- Requires: - QubesOS/qubes-linux-utils#140
This was referenced Aug 7, 2026
Merged
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026080820-devel&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2026050504-devel&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/176874#dependencies 32 fixed
Unstable testsDetails
Performance TestsPerformance degradation:18 performance degradations
Remaining performance tests:93 tests
|
This was referenced Aug 7, 2026
marmarek
requested changes
Aug 8, 2026
Comment on lines
+106
to
+107
| data->mem = ret_mem; | ||
| data->swap = ret_swap; |
Member
There was a problem hiding this comment.
Those two may be uninitialized at this point. Maybe simply set to NULL at the start?
This was referenced Aug 9, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows distinguishing how much memory the qube is using from what is assigned by using "meminfo - swapinfo".
For: QubesOS/qubes-core-admin#827
Tested briefly.