Fix multi language feature#102
Merged
Merged
Conversation
toonvandenbos
left a comment
toonvandenbos
left a comment
Member
There was a problem hiding this comment.
Good one!
However, could you add a comment on the getAttribute() method, indicating why closure are resolved when accessing the attribute? The idea is to explain the translations problem for future maintainers.
…correct locale translations
|
Any updates? |
toonvandenbos
approved these changes
Dec 12, 2025
Member
|
Hi @johannesMEGABAD, this PR is ready but will be tagged for release with the other changes prepared for |
Oh wow uhh that was quick haha :D Nice!! Looking forward to it ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve #71 using a closure to ensure the translation respects the current locale:
Each attribute now uses setAttribute with a closure that calls the translate method. The closures are only executed when the view accesses the attributes, ensuring that the current locale has already been set and translations are rendered correctly.