Skip to content

fix(evidence): use plain GitHub Markdown line links #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BlueboxC wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

fix(evidence): use plain GitHub Markdown line links #1147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28d3612
fix(evidence): use plain GitHub Markdown line links
BlueboxC Oct 28, 2026
e398d2e
chore(ci): update evidence branch with merged dev
BlueboxC Oct 29, 2026
4784873
Merge current dev for PR #1147 and refresh generated artifacts
BlueboxC Oct 31, 2026
355ea38
Refresh README animation after Sequence header centering
BlueboxC Oct 31, 2026
e4241a7
Merge README animation refresh from PR #1174
BlueboxC Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified archify.zip
View file
Open in desktop
Binary file not shown.
6 changes: 3 additions & 3 deletions archify/renderers/shared/repository-location.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ export function repositorySourceHref(provider, url, revision, source) {
const end = source.endLine && source.endLine !== source.line
? `-${provider === 'github' ? 'L' : ''}${source.endLine}` : '';
const fragment = source.line ? `#L${source.line}${end}` : '';
if (provider !== 'gitlab') return `${url}/blob/${revision}/${encodedPath}${fragment}`;
// GitLab renders Markdown blobs, where line anchors select nothing; the
// GitHub and GitLab render Markdown blobs, where line anchors select nothing; the
// plain view keeps the cited lines highlighted.
const plain = source.line && /\.(?:md|markdown)$/i.test(source.path) ? '?plain=1' : '';
const plain = ['github', 'gitlab'].includes(provider) && source.line && /\.(?:md|markdown)$/i.test(source.path) ? '?plain=1' : '';
if (provider !== 'gitlab') return `${url}/blob/${revision}/${encodedPath}${plain}${fragment}`;
return `${url}/-/blob/${revision}/${encodedPath}${plain}${fragment}`;
}

Expand Down
Binary file modified docs/assets/archify-live-proof.gif
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions docs/assets/archify-live-proof.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"fps": 10,
"frameCount": 54,
"durationSeconds": 5.4,
"bytes": 843870,
"sha256": "b1352f9557026653aeeccac19e11d26f5d24eca8ab013e6c7058529211838c9b",
"bytes": 836293,
"sha256": "46aaacb2d93c0d781da4f7de8063ea0a8b08c59430cfe678258a20624ea4859b",
"scenes": [
{
"id": "signal-flow",
Expand All @@ -31,7 +31,7 @@
{
"id": "classic",
"artifact": "docs/gallery/artifacts/cache-miss.sequence.html",
"artifactSha256": "7f68d7303c86988cfbe228202d25fc6da42fb174be47df5f637d57c39fbf5766",
"artifactSha256": "ca273484a235600f96a74351ac3976cdb6bffb1cfb5d0b86f9ced8c21bd1aa80",
"hash": "#route=web~db",
"eyebrow": "SEQUENCE · CLASSIC",
"title": "Cache Miss Request",
Expand Down
10 changes: 10 additions & 0 deletions test/repository-markdown-lines.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import test from 'node:test';
import assert from 'node:assert/strict';
import { repositorySourceHref } from '../archify/renderers/shared/repository-location.mjs';
test('GitHub Markdown line citations use plain source and preserve other links',()=>{
const url='https://github.com/example/repo',rev='a'.repeat(40);
for(const name of ['README.md','guide.MARKDOWN']) assert.equal(repositorySourceHref('github',url,rev,{path:name,line:1,endLine:3}),`${url}/blob/${rev}/${name}?plain=1#L1-L3`);
assert.equal(repositorySourceHref('github',url,rev,{path:'README.md'}),`${url}/blob/${rev}/README.md`);
assert.equal(repositorySourceHref('github',url,rev,{path:'a.js',line:2}),`${url}/blob/${rev}/a.js#L2`);
assert.equal(repositorySourceHref('gitee',url,rev,{path:'README.md',line:2}),`${url}/blob/${rev}/README.md#L2`);
});
Loading