Repository navigation
Conversation
Regression for tt-a1i#1128.
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Contribution Scope |  |
The evidence-link fix is clearly scoped and documented, including the user problem, preserved provider behavior, linked issue, and maintainer scope decision. However, the reviewed diff also changes `d… | Remove the unrelated README animation commits and generated artifacts from this PR, or split them into a separate PR. Then update the description so it matches the final reviewed diff. |
| Validation Evidence | |
Validation evidence has a current-head gap. I evaluated base 63c9263 against head e4241a7. The helper change and regression test were introduced at 28d3612 and remained unchanged through the head. … | Run and record validation at head e4241a7, or link a CI run that explicitly covers that revision: run the generated-output checks, rebuild archify.zip and compare exact bytes, and run the extracted-package smoke check. Review the changed G… |
Full details: Contribution Scope
-
Explanation
The evidence-link fix is clearly scoped and documented, including the user problem, preserved provider behavior, linked issue, and maintainer scope decision. However, the reviewed diff also changes
docs/assets/archify-live-proof.gifand.jsonthrough commits titledRefresh README animation after Sequence header centeringandMerge README animation refresh from PR #1174. These files are unrelated to repository evidence links. The description also claims the final diff is limited to three correction files, which conflicts with the authoritative five-file diff.Resolution
Remove the unrelated README animation commits and generated artifacts from this PR, or split them into a separate PR. Then update the description so it matches the final reviewed diff.
Full details: Validation Evidence
-
Explanation
Validation evidence has a current-head gap. I evaluated base 63c9263 against head e4241a7. The helper change and regression test were introduced at 28d3612 and remained unchanged through the head. The focused test covers GitHub Markdown, no-line, code-file, and Gitee cases; existing repository-evidence tests cover the caller and GitLab Markdown links. The author reports the base regression, focused tests, full tests, generated checks, and ZIP smoke passed. I observed that git diff --check passes, the current ZIP contains the current helper, and the GIF metadata matches the GIF. However, commits 4784873 and e4241a7 changed archify.zip and the README animation after the reported candidate. The supplied CI success is not tied to e4241a7, and no current-head package freshness or comparable visual review is evidenced. The claim that the diff is limited to three correction files is also inconsistent with the authoritative five-file diff.
Resolution
Run and record validation at head e4241a7, or link a CI run that explicitly covers that revision: run the generated-output checks, rebuild archify.zip and compare exact bytes, and run the extracted-package smoke check. Review the changed GIF with a comparable before/after visual check or link equivalent upstream evidence. Update the PR body to list the five changed files and distinguish reused behavior evidence from current-head generated-output evidence. Do not rerun the focused repository test solely for later generated-only changes; the source and regression test are unchanged.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
|
The bounded scope is accepted, and I have personally reviewed this candidate, its explanation and results. The description now records that confirmation. This stays Draft because CI run 40764382916 is still red on unchanged head Please review the code while the external CI dependency remains open. @coderabbitai review BlueboxC |
✅ Action performed
|
Include the merged baseline artifact repair while preserving the three correction files byte-for-byte. BlueboxC
|
Updated this contributor branch with the maintainer-merged #1150 base BlueboxC |
Preserve the original correction while regenerating the combined source package. BlueboxC
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Recapture the existing scenes from the current gallery artifacts after upstream PR tt-a1i#1173. BlueboxC
Retain the original correction and upstream Sequence centering; bind the animation to the combined gallery artifacts. BlueboxC
Problem and value
Related: #1128.
GitHub renders Markdown by default, so a repository evidence URL ending in
README.md#L1does not select the intended source line. Add?plain=1only for GitHub Markdown links carrying a line reference; retain existing code-file, no-line, GitLab and Gitee behavior.The maintainer accepted this bounded scope in the scope review. PR #1063 adds GitHub Enterprise provider support; it does not implement this plain Markdown line-link behavior.
Contributor review
The accountable contributor explicitly confirmed personal review of this candidate, its explanation and visible results on 2026-10-29.
Stability impact
Shared repository evidence behavior. The change is bounded to the behavior described above. Test-value review selected observable content/URL/acceptance regressions rather than implementation snapshots: each new regression fails on the base and passes with this fix. Existing related coverage is reused. No separate simplify-codebase refactor was needed for this local correction; no speculative abstraction or configuration is added.
Tests run
Base:
847146aeb93b492592adb78dc220f57e4a8b4636(dev). Original qualified candidate:28d3612d7ae9f4e2acb0bd3e03d9fc7b00af1d23(the same three correction files are retained in the updated candidate below).Node 22.23.2, macOS arm64, zlib 1.3.1-e00f703:
node --test test/repository-markdown-lines.test.mjs— fails, exposing the reported behavior.npm run test:focus -- test/repository-markdown-lines.test.mjs test/repository-evidence.test.mjs— passes.npm testandnpm run test:generated— pass.git diff --check— passes.bash scripts/build-zip.sh— passes; extracted ZIP smoke passes for the changed behavior.These are fixed-input regressions and scoped core/generated checks. The local results above retain their original scope. No real-repository Agent generation benchmark is claimed. The current remote CI results are recorded below.
Generated artifacts
Regenerated
archify.zipfrom the candidate source using the canonical Node/zlib toolchain. SHA-256:4c588d79741980efde56c380c2e43fcccf6714e4d63cf4ced369087da7abc8bf. The extracted distribution was exercised; no release or deployment is requested by this PR.Upstream CI follow-up
The full-suite checks on this PR expose two failures also reproduced on the unmodified comparison base
847146aeb93b492592adb78dc220f57e4a8b4636:Both fail before applying this change. Regenerating the Checkout comparison produces the same bytes on the base and this candidate (SHA-256
f8a0f1c4e0023d306fd59ba88d6c11811cde985f40b1ec48ce3c63e44615aef6), so unrelated checked-in examples/README assets were left out of this correction.The short-wide Sequence input HTML is byte-identical on base and candidate (SHA-256
6f8817a3662545a79bc8317c58b9992250c0a04ff44dd12439191790f755c002). The browser failure has now been reproduced independently with a controlled initial header-height transition; #1151 supplies the separate Reader fix and discriminating regression. #1150 repairs the two stale derived artifacts. Those PRs carry their own tests and generated outputs; this PR retains its original evidence-link scope. The earlier failed run remains historical; the current result after integrating #1150 is recorded below. #1151 remains pending upstream.Review status at the previously reviewed head
#1150 was merged by the maintainer into
devat12b476771f81ad48da14946653dfbb8b5d347961on 2026-10-29. This contributor branch now includes that base ate398d2e0e8904db85e831455f8db1fa74ecd1e15. Its renderer/verifier change, regression test and ZIP are byte-for-byte identical to the personally reviewed candidate; the PR diff still contains only those three correction files. Existing focused/package evidence and personal review apply to those unchanged files.CI run 40866355238 passed on this updated head: 19 successful jobs, no failures, and two expected deployment skips. Both full-regression shards and both browser shards executed and passed, together with Node 18/20/22/24, native Windows portability, package smoke on Linux/macOS/Windows, generated/ZIP freshness, website and artifact gates. The earlier failed run remains historical. Personal review covers the unchanged correction files; there are no unresolved review threads. This candidate meets the recorded requirements for review.
#1151 remains the separate Sequence fit correction for the independently reproduced earlier browser failure. A passing run here does not establish that the Markdown-link correction repairs that behavior. Coordinate the shared helper with #1063 during integration.
Current integration · 31 October
Head
e4241a7b48d8b739ec4d0d6ffa3a71fa6116abd0includes maintainer #1173 and dev63c9263e84bd3993cab8e09b3d69888857858635. The original correction and test blobs remain byte-identical toe398d2e0e8904db85e831455f8db1fa74ecd1e15; the existing personal confirmation retains that scope. The combined ZIP was regenerated and checked against the complete Skill tree.Local qualification on tree
d95b7f7a85a62b8b969393525c3267ffb5487155: generated/golden checks,19 core smoke cases,26 focused Sequence cases including Chrome, this PR's focused regression and clean-package smoke. The later integration of #1174 changes only the README GIF and receipt: the unchanged README/Gallery tests pass15 cases with one native Windows-only local skip on final tree0479fdf0be093a1b144078bdf89cffbfa654a313. All three input-artifact hashes match the separately recaptured #1174 animation. Source, tests and ZIP are unchanged by that second step. The earlier README freshness failures remain visible in the previous CI runs.CI41175238754 passed on this exact public head: 19 successful jobs, 2 expected skips, no failures. Both complete regression shards executed and passed. Both native Windows Node22/24 path-test gates executed and passed. Deployment jobs were skipped. The separate generated-media PR1174 remains Draft pending its own personal review; this update does not claim a new personal review of these mechanical commits.
BlueboxC