Skip to content

chore(ci): drop the saas-ambient baseline entry #7181 fixed #7186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senamakel merged 1 commit into from
Oct 9, 2026
Merged

chore(ci): drop the saas-ambient baseline entry #7181 fixed #7186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions scripts/ci/saas-ambient-baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
{
"rule": "home-dir",
"path": "crates/openhuman-core/src/core/runtime/saas.rs",
"line": 177,
"line": 181,
"text": "home: dirs::home_dir(),",
"occurrence": 1
},
Expand Down Expand Up @@ -601,13 +601,6 @@
"text": "tokio::task::spawn_blocking(move || load_app_session_profile(&config_for_profile))",
"occurrence": 1
},
{
"rule": "bare-spawn",
"path": "crates/openhuman-core/src/desktop/notifications/rpc.rs",
"line": 91,
"text": "tokio::spawn(async move {",
"occurrence": 1
},
{

@tinysweeper tinysweeper Bot Oct 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

priority high critique confident

Keep the unchanged bare-spawn violation in the baseline

The bare-spawn record for crates/openhuman-core/src/desktop/notifications/rpc.rs is removed, but the supplied pull request does not change that source file or the recorded tokio::spawn(async move { occurrence. The ambient check will therefore see this existing violation as un-baselined and can fail CI. Restore this entry unless the corresponding source violation is removed in the same change.

[RULE] stale-baseline ·

"rule": "bare-spawn",
"path": "crates/openhuman-core/src/flows/bus/trigger.rs",
Expand Down Expand Up @@ -646,7 +639,7 @@
{
"rule": "bare-spawn",
"path": "crates/openhuman-core/src/inference/host_runtime/ops/agent_chat.rs",
"line": 397,
"line": 443,
"text": "tokio::spawn(async move { while rx.recv().await.is_some() {} });",
"occurrence": 1
},
Expand Down Expand Up @@ -1353,7 +1346,7 @@
{
"rule": "bare-spawn",
"path": "crates/openhuman-core/src/web_chat/ops/state.rs",
"line": 88,
"line": 102,
"text": "tokio::spawn(async move {",
"occurrence": 1
},
Expand Down
Loading