chore(ci): drop the saas-ambient baseline entry #7181 fixed by senamakel · Pull Request #7186 · tinyhumansai/openhuman

senamakel · 2026-10-09T11:50:58Z

Summary

Tighten scripts/ci/saas-ambient-baseline.json after feat(storage): devices, notifications and task sources on the storage ports #7181: its notification triage now starts through spawn_scoped, so the bare-spawn site in desktop/notifications/rpc.rs is gone and the ratchet requires removing it from the baseline. The other entries only move line numbers.

Problem

node scripts/ci/check-saas-ambient.mjs fails on main since feat(storage): devices, notifications and task sources on the storage ports #7181 ("Fixed sites still in the baseline (1); remove them"), which turns the saas-ambient lane red for every PR.

Solution

node scripts/ci/check-saas-ambient.mjs --write-baseline, then the check passes: 196 baselined sites, one fewer than before.

Submission Checklist

Tests added or updated: N/A, a CI baseline refresh; the ratchet itself is the check.
Diff coverage ≥ 80%: N/A, no source lines changed.
Coverage matrix updated: N/A.
Affected feature IDs: N/A.
No new external network dependencies.
Manual smoke checklist: N/A.
Linked issue: N/A, follow-up to feat(storage): devices, notifications and task sources on the storage ports #7181.

Impact

CI only.

Closes: N/A
Follow-up to feat(storage): devices, notifications and task sources on the storage ports #7181.
Follow-up PR(s)/TODOs: carry the agent scope into the background producers that now reach the storage ports (device pairing events, the notification bridge, cron alerts, the task-source poller); in SaaS mode they currently resolve no acting agent.

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

Key: N/A
URL: N/A

Commit & Branch

Branch: storage-main-fixups
Commit SHA: see the PR head

Validation Run

pnpm --filter openhuman-app format:check: N/A
pnpm typecheck: N/A
Focused tests: node scripts/ci/check-saas-ambient.mjs passes
Rust fmt/check (if changed): N/A
Tauri fmt/check (if changed): N/A

Validation Blocked

command: N/A
error: N/A
impact: N/A

Behavior Changes

Intended behavior change: none.
User-visible effect: none.

Parity Contract

Legacy behavior preserved: yes.
Guard/fallback/dispatch parity checks: N/A.

Duplicate / Superseded PR Handling

Duplicate PR(s): none
Canonical PR: this one
Resolution (closed/superseded/updated): N/A

Update the ambient baseline to match current source line numbers and drop the bare-spawn entry for the notifications RPC, which no longer contains that call. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>

tinysweeper · 2026-10-09T11:51:04Z

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 1 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Changes requested
Priority: high
Reviewed head: 38a51126e844
Updated: 1791546710 (Unix time)

Review snapshot

Change surface	Files	Review signal	Count
Production	0	Active findings	1
Tests	0	Noted findings	0
Documentation	0	Resolved findings	0
Configuration	1	Pending checks/questions	0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

high · critique · Keep the unchanged bare-spawn violation in the baseline — The `bare-spawn` record for `crates/openhuman-core/src/desktop/notifications/rpc.rs` is removed, but the supplied pull request does not change that source file or the recorded `tok (scripts/ci/saas\-ambient\-baseline\.json:604)

Before merge

Address Keep the unchanged bare-spawn violation in the baseline (scripts/ci/saas\-ambient\-baseline\.json).

Agent review details

critique

Conclusion: Failure
Scope reviewed: all assigned evidence
Lane summary: This change only removes an ambient-baseline entry while the corresponding source violation is unchanged in the supplied diff, so the CI baseline will no longer match the scan results. It is not safe to merge as written. _Code retrieval was unavailable (model: ladder embeddings returned 400 Bad Request: {"error":{"message":"unknown ladder vectors; known ladders are flash (also chat-v1, flash-v1), instant (also no-think, instant-v1), reasoning (also deepseek), max-reasoning (also max-reasoning-v1), deepseek-flash (also reasoning-v1, agentic-v1), deep (also luna), scribe, uncensored, vectors-oai3 (also embeddings-oai3-v1), vision (also vision-v1, multimodal-v1), image (also images-v1, image-v1), vi), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: error sending request for url (http://cortexdb:3141/v1/recall\)\), so this review ran without it._
Evidence: scripts/ci/saas\-ambient\-baseline\.json — Keep the unchanged bare-spawn violation in the baseline

security

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The baseline updates only adjust recorded locations and remove an obsolete finding; this change looks safe to merge. _Code retrieval was unavailable (model: ladder embeddings returned 400 Bad Request: {"error":{"message":"unknown ladder vectors; known ladders are flash (also chat-v1, flash-v1), instant (also no-think, instant-v1), reasoning (also deepseek), max-reasoning (also max-reasoning-v1), deepseek-flash (also reasoning-v1, agentic-v1), deep (also luna), scribe, uncensored, vectors-oai3 (also embeddings-oai3-v1), vision (also vision-v1, multimodal-v1), image (also images-v1, image-v1), vi), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: error sending request for url (http://cortexdb:3141/v1/recall\)\), so this review ran without it._

tests

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: Nothing sensitive found in what this pull request commits.

description

Conclusion: Success
Scope reviewed: all assigned evidence
Lane summary: The diff refreshes the saas-ambient baseline exactly as described: the fixed bare-spawn site in desktop/notifications/rpc.rs is removed and three other entries shift line numbers. The description matches the change; safe to merge. _Code retrieval was unavailable (model: ladder embeddings returned 400 Bad Request: {"error":{"message":"unknown ladder vectors; known ladders are flash (also chat-v1, flash-v1), instant (also no-think, instant-v1), reasoning (also deepseek), max-reasoning (also max-reasoning-v1), deepseek-flash (also reasoning-v1, agentic-v1), deep (also luna), scribe, uncensored, vectors-oai3 (also embeddings-oai3-v1), vision (also vision-v1, multimodal-v1), image (also images-v1, image-v1), vi), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: error sending request for url (http://cortexdb:3141/v1/recall\)\), so this review ran without it._

e2e

Conclusion: Neutral
Scope reviewed: all assigned evidence
Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

Evidence and run details

Models: gpt-5.6-luna, glm-5.3-flash
Spend: $0.000198
Tokens: 17389 input · 1613 output · 3834 cached · 0 embedding

Head	State	Pass summary
`38a51126e844`	changes requested	1 active finding(s), 0 resolved finding(s) (at 1791546710)

chatgpt-codex-connector · 2026-10-09T11:51:12Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T11:52:42.618179Z	`38a5112`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

tinysweeper

Requesting changes: 1 lane(s) blocking, worst finding is high.

Fix or reply to the findings below and push. The next review clears this automatically once they are gone — you should not need to dismiss anything by hand.

             $0.0002 · 17,389 in / 1,613 out · 3,834 cached (22%) · gpt-5.6-luna, glm-5.3-flash
critique:    $0.0001 · 6,185 in  / 854 out   · 512 cached (8%)    · gpt-5.6-luna, glm-5.3-flash
security:    $0.0000 · 4,448 in  / 185 out   · 1,786 cached (40%) · gpt-5.6-luna
description: $0.0000 · 4,531 in  / 87 out    · 1,408 cached (31%) · glm-5.3-flash

tinysweeper · 2026-10-09T11:52:02Z

-    "text": "tokio::spawn(async move {",
-    "occurrence": 1
-  },
  {


Keep the unchanged bare-spawn violation in the baseline

The bare-spawn record for crates/openhuman-core/src/desktop/notifications/rpc.rs is removed, but the supplied pull request does not change that source file or the recorded tokio::spawn(async move { occurrence. The ambient check will therefore see this existing violation as un-baselined and can fail CI. Restore this entry unless the corresponding source violation is removed in the same change.

[RULE] stale-baseline ·

coderabbitai · 2026-10-09T11:52:27Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: e7fe7ab5-098c-453b-9b69-2c663f89d4a6

📥 Commits

Reviewing files that changed from the base of the PR and between 5e8ca60 and 38a5112.

📒 Files selected for processing (1)

scripts/ci/saas-ambient-baseline.json

 ___________________________________________
< Crossing the tensor streams to find bugs. >
 -------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

chore(ci): refresh saas ambient baseline

38a5112

Update the ambient baseline to match current source line numbers and drop the bare-spawn entry for the notifications RPC, which no longer contains that call. Auto-committed-on: dragonfly Co-authored-by: Medulla <medulla@tinyhumans.ai>

tinysweeper Bot suggested changes Oct 9, 2026

View reviewed changes

tinysweeper Bot added the priority: p1 Next. Wrong behaviour a user will hit, or a security weakness behind a condition. label Oct 9, 2026

senamakel merged commit 26a6829 into tinyhumansai:main Oct 9, 2026
20 of 24 checks passed

senamakel mentioned this pull request Oct 9, 2026

feat(storage): cron and flows on the storage ports #7187

Merged

12 tasks done

Navigation Menu

Repository navigation

chore(ci): drop the saas-ambient baseline entry #7181 fixed - #7186

chore(ci): drop the saas-ambient baseline entry #7181 fixed#7186
senamakel merged 1 commit into
tinyhumansai:mainfrom
senamakel:storage-main-fixups

senamakel commented Oct 9, 2026

Uh oh!

tinysweeper Bot commented Oct 9, 2026 •

edited

Loading

critique

security

tests

commits

description

e2e

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading

Uh oh!

tinysweeper Bot left a comment

Uh oh!

tinysweeper Bot Oct 9, 2026

Uh oh!

coderabbitai Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

senamakel commented Oct 9, 2026

Summary

Problem

Solution

Submission Checklist

Impact

Related

AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

Commit & Branch

Validation Run

Validation Blocked

Behavior Changes

Parity Contract

Duplicate / Superseded PR Handling

Uh oh!

tinysweeper Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tiny Sweeper review

Review snapshot

What changed

Features

Tests

Findings

Before merge

critique

security

tests

commits

description

e2e

Uh oh!

chatgpt-codex-connector Bot commented Oct 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

tinysweeper Bot left a comment

Choose a reason for hiding this comment

Uh oh!

tinysweeper Bot Oct 9, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Oct 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tinysweeper Bot commented Oct 9, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 9, 2026 •

edited

Loading