Repository navigation
fix(modules): hotfix module admission so search and memory load on installed builds - #7155
Conversation
Update the vendored tinybus submodule to the latest upstream commit. Auto-committed-on: macbook Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Update the vendored tinybus submodule to a newer revision. Auto-committed-on: macbook Co-authored-by: Medulla <medulla@tinyhumans.ai>
Tiny Sweeper reviewTiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below. State: Ready for maintainer review Review snapshot
Completeness: Complete What changedThe review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below. FeaturesNone identified with supported citations. TestsNo supported feature-to-test mapping was produced. Test execution is not inferred. FindingsNo active actionable findings. Before mergeNone. Agent review detailscritique
security
tests
commits
description
e2e
Evidence and run details
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Summary
release(0.64.x). Bumpsvendor/tinybusto fix(module): admit /Applications installs, private release cache, fall back on placement-only bundle refusals tinybus#36 and Set Up Sentry to Production #37 (merged,356bb24) so installed apps can load modules again. Right now search (tinysearch) and memory (tinymemory) fail withmodule directory is writable by another user.Problem
In production Langfuse, 18 of the last 100
web_search_toolcalls (Oct 7–9, v0.64.7–0.64.14) failed with:The same error appears for
windows-2022-x86_64andubuntu-22.04-x86_64. Sentry CORE-RUST-35W and CORE-RUST-365 show the same refusal fortinymemory./Applicationsisroot:admin 0775, so every bundled module in a normal install is refused.002→0775), so the gate refused the cache it had just filled.C:\Program Files, whose folders grant TrustedInstaller Full Control, and the ACL rule did not trust it.Solution
tinybus#36:
admin). World write, other groups and other owners are still refused.0700, and removes group/other write from cache directories the user owns.Submission Checklist
admission_testsrun on real ubuntu, macOS and Windows runners: the bundle-open-to-others fallback end to end, the real/Applications, and umask002.Impact
/Applications; Linux caches stop being refused; a placement-refused bundle recovers by downloading the pinned release.C:\Program Filesare now admitted (tinybus#37: TrustedInstaller trusted, inherit-only ACEs judged on the files they seed). Verified on the Windows runner against a real%ProgramFiles%directory.Related
/Applications, private release cache, placement-only fallback (merged)AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
tinybus-module-admissionValidation Run
pnpm --filter openhuman-app format:check: N/A, no frontend changepnpm typecheck: N/Acargo test -p openhuman --lib modules::: 151 passed against the new tinybusfmt --check,clippy -D warnings,test --all-features(411 passed),--no-default-featuresValidation Blocked
command:Windows cross-build locallyerror:ringbuild script fails cross-compiling from macOSimpact:Windows runs only on tinybus CI'smodulesjobBehavior Changes
/Applicationsand in umask-002caches are admitted; a placement-only bundle refusal falls back to the release cache.Parity Contract
a_bundle_refused_for_its_content_is_still_authoritative, plus the existing marker and invalid-bundle tests.Duplicate / Superseded PR Handling