Skip to content

CHI-3707: Add test coverage for current user identity check in masking logic #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenhand merged 2 commits into from
Feb 6, 2026
Merged

CHI-3707: Add test coverage for current user identity check in masking logic #3876

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a301711
Initial plan
Copilot Feb 6, 2026
f15f7b2
Add test coverage for participant identity matching manager user
Copilot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions plugin-hrm-form/src/___tests__/maskIdentifiers/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ describe('maskConversationServiceUserNames', () => {
strings: {
MaskIdentifiers: 'MASKED',
},
user: {
identity: 'current-user-identity',
},
store: {
subscribe: jest.fn((callback: () => void) => {
storeSubscribeCallback = callback;
Expand All @@ -56,10 +59,11 @@ describe('maskConversationServiceUserNames', () => {
jest.clearAllMocks();
});

const createParticipant = (sid: string, attributes: Record<string, any> = {}) => ({
const createParticipant = (sid: string, attributes: Record<string, any> = {}, identity?: string) => ({
source: {
sid,
attributes,
...(identity && { identity }),
},
friendlyName: 'Original Name',
});
Expand All @@ -78,6 +82,27 @@ describe('maskConversationServiceUserNames', () => {
});

each([
{
testCase: 'identity matches manager user identity, regardless of other checks',
participantAttributes: {},
participantIdentity: 'current-user-identity',
flexParticipants: {},
expectedName: 'Original Name',
},
{
testCase: 'identity matches manager user identity, even with guest member_type',
participantAttributes: { member_type: 'guest' },
participantIdentity: 'current-user-identity',
flexParticipants: {},
expectedName: 'Original Name',
},
{
testCase: 'identity matches manager user identity, even when not in flex store',
participantAttributes: {},
participantIdentity: 'current-user-identity',
flexParticipants: { participant1: { type: 'customer', sid: 'MB999' } },
expectedName: 'Original Name',
},
{
testCase: 'no member_type attribute and not in flex store as agent',
participantAttributes: {},
Expand Down Expand Up @@ -122,10 +147,10 @@ describe('maskConversationServiceUserNames', () => {
},
]).test(
'participant should have correct masking when $testCase',
({ participantAttributes, flexParticipants, expectedName }) => {
({ participantAttributes, participantIdentity, flexParticipants, expectedName }) => {
const conversationSid = 'CH123';
const participantSid = 'MB456';
const participant = createParticipant(participantSid, participantAttributes);
const participant = createParticipant(participantSid, participantAttributes, participantIdentity);

const bySid: Record<string, ReturnType<typeof createFlexParticipant>> = {};
Object.entries(flexParticipants).forEach(([key, value]) => {
Expand Down
Loading