CHI-3707: Add test coverage for current user identity check in masking logic#3876
Merged
stephenhand merged 2 commits intoCHI-3707-mask_participants_missing_from_reduxfrom Feb 6, 2026
Conversation
Merged
6 tasks
Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add separate check for identifying current user in conversation
CHI-3707: Add test coverage for current user identity check in masking logic
Feb 6, 2026
stephenhand
approved these changes
Feb 6, 2026
60c7aa2
into
CHI-3707-mask_participants_missing_from_redux
26 of 27 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extended unit test coverage for the redux subscribe function that masks conversation participant identifiers. Added tests verifying that participants matching the current user's identity are correctly identified as agents regardless of other attribute checks.
Changes
Test coverage for identity-based agent check: Added three test cases verifying that when
participant.source.identity === manager.user.identity, the participant is identified as an agent, overriding:member_type: 'guest'attributeTest infrastructure updates:
createParticipanthelper to accept optionalidentityparameteruser.identityto mock manager setupChecklist
Other Related Issues
None
Verification steps
Run test suite:
npm test -- src/___tests__/maskIdentifiers/index.test.tsAll 18 tests pass, including 3 new test cases for identity matching.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.