Skip to content

CHI-3707: Add test coverage for current user identity check in masking logic#3876

Merged
stephenhand merged 2 commits intoCHI-3707-mask_participants_missing_from_reduxfrom
copilot/sub-pr-3872-again
Feb 6, 2026
Merged

CHI-3707: Add test coverage for current user identity check in masking logic#3876
stephenhand merged 2 commits intoCHI-3707-mask_participants_missing_from_reduxfrom
copilot/sub-pr-3872-again

Conversation

Copy link
Contributor

Copilot AI commented Feb 6, 2026

Description

Extended unit test coverage for the redux subscribe function that masks conversation participant identifiers. Added tests verifying that participants matching the current user's identity are correctly identified as agents regardless of other attribute checks.

Changes

  • Test coverage for identity-based agent check: Added three test cases verifying that when participant.source.identity === manager.user.identity, the participant is identified as an agent, overriding:

    • Empty or missing attributes
    • member_type: 'guest' attribute
    • Absence from flex participants store
  • Test infrastructure updates:

    • Extended createParticipant helper to accept optional identity parameter
    • Added user.identity to mock manager setup

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags added
  • Strings are localized
  • Tested for chat contacts
  • Tested for call contacts

Other Related Issues

None

Verification steps

Run test suite: npm test -- src/___tests__/maskIdentifiers/index.test.ts

All 18 tests pass, including 3 new test cases for identity matching.

AFTER YOU MERGE

  1. Cut a release tag using the Github workflow. Wait for it to complete and notify in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: stephenhand <1694716+stephenhand@users.noreply.github.com>
Copilot AI changed the title [WIP] Add separate check for identifying current user in conversation CHI-3707: Add test coverage for current user identity check in masking logic Feb 6, 2026
Copilot AI requested a review from stephenhand February 6, 2026 13:51
@stephenhand stephenhand marked this pull request as ready for review February 6, 2026 14:03
@stephenhand stephenhand merged commit 60c7aa2 into CHI-3707-mask_participants_missing_from_redux Feb 6, 2026
26 of 27 checks passed
@stephenhand stephenhand deleted the copilot/sub-pr-3872-again branch February 6, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants