Skip to content

refactor: Import WebSocketServer properly #3290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mondoreale merged 1 commit into from
Dec 11, 2025
Merged

refactor: Import WebSocketServer properly #3290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/dht/src/connection/websocket/WebsocketServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { createServer as createHttpServer, Server as HttpServer, IncomingMessage, ServerResponse } from 'http'
import { createServer as createHttpsServer, Server as HttpsServer } from 'https'
import EventEmitter from 'eventemitter3'
import WebSocket from 'ws'
import WebSocket, { WebSocketServer } from 'ws'
import { WebsocketServerConnection } from './WebsocketServerConnection'
import { Logger, asAbortable } from '@streamr/utils'
import { createSelfSignedCertificate } from '@streamr/autocertifier-client'
Expand Down Expand Up @@ -29,7 +29,7 @@ interface Events {
export class WebsocketServer extends EventEmitter<Events> {

private httpServer?: HttpServer | HttpsServer
private wsServer?: WebSocket.Server
private wsServer?: WebSocketServer
private readonly abortController = new AbortController()
private readonly options: WebsocketServerOptions

Expand Down Expand Up @@ -154,9 +154,9 @@ export class WebsocketServer extends EventEmitter<Events> {
})
}

private createWsServer(): WebSocket.Server {
private createWsServer(): WebSocketServer {
const maxPayload = this.options.maxMessageSize ?? 1048576
return this.wsServer = new WebSocket.Server({
return this.wsServer = new WebSocketServer({
noServer: true,
maxPayload
})
Expand Down