refactor: Import WebSocketServer properly#3290
Merged
Merged
Conversation
juslesan
approved these changes
Dec 11, 2025
teogeb
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
dhtpackage’sWebsocketServerto correctly use the namedWebSocketServerexport introduced in ws v8+, improving clarity and type consistency.Note
The current
WebSocket.Serverway works as long as we target CJS and not ESM. The new way works for both.Changes
WebsocketServer.ts(mind the low-key "s") to import the server using the properimport { WebSocketServer } from 'ws'syntax, distinguishing it from the WebSocket client type.WebSocket.Servertype references and instantiations withWebSocketServerfor consistent and accurate typing.