Skip to content

fix: fix incompelete or incorrent stuff introduced by #20 and #21#22

Merged
sbalghari merged 1 commit into
mainfrom
fixes
May 31, 2026
Merged

fix: fix incompelete or incorrent stuff introduced by #20 and #21#22
sbalghari merged 1 commit into
mainfrom
fixes

Conversation

@sbalghari

@sbalghari sbalghari commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

Release Notes

  • Chores
    • Transitioned service installation to user-level services only
    • Updated service startup configurations and references
    • Removed example system service file

@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f03f1992-dfb9-4598-af47-3532e96b8748

📥 Commits

Reviewing files that changed from the base of the PR and between 8271f4a and 17c29a1.

📒 Files selected for processing (7)
  • packaging/archlinux/PKGBUILD
  • services/sbdots-actions.service
  • services/sbdots-clipboard-listener.service
  • services/system/sbdots-example.service
  • src/sbdots/daemons/actions.py
  • src/sbdots/daemons/cliplistener.py
  • src/sbdots/lifecycle/postinstall/start_service.py
💤 Files with no reviewable changes (1)
  • services/system/sbdots-example.service

📝 Walkthrough

Walkthrough

This PR consolidates systemd service architecture by updating daemon module references in service units, simplifying installation to user-only services via updated PKGBUILD logic, and refactoring service discovery to use a generic path-based helper instead of separate user/system discovery functions.

Changes

Systemd services to user-only with module updates

Layer / File(s) Summary
Service unit daemon module updates
services/sbdots-actions.service, services/sbdots-clipboard-listener.service
Service unit files update ExecStart references: sbdots.daemons.actions_dsbdots.daemons.actions, and sbdots.daemons.cliplistener_dsbdots.daemons.cliplistener; clipboard-listener description is also updated.
Installation and service discovery consolidation
packaging/archlinux/PKGBUILD, src/sbdots/lifecycle/postinstall/start_service.py
PKGBUILD installs all services/*.service files to user systemd directory only, removing the previous split between user and system service directories. Service discovery is refactored from separate _get_available_user_services() and _get_available_system_services() to a single generic _get_available_services(path: Path) helper; system-level service discovery and logging are removed from start_services().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • sbalghari/sbdots#20: Related systemd refactoring affecting the same files (PKGBUILD, start_service.py, and service unit definitions); this PR consolidates the user-only service model introduced in PR #20 by removing system-level service handling.

Poem

🐰 Services now speak with cleaner names,
No more _d and system games,
Just user paths, a path so true,
One helper reigns where once were two!
The install grows simpler, lighter, free. ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title references fixing issues from previous PRs but uses non-standard spelling ('incompelete', 'incorrent') and vague language ('stuff'), making it unclear what the actual changes accomplish. Revise the title to use correct spelling and be more specific about what was fixed, e.g., 'fix: consolidate systemd service installation to user-level only' or similar.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbalghari sbalghari merged commit f497415 into main May 31, 2026
2 checks passed
@sbalghari sbalghari deleted the fixes branch May 31, 2026 03:58
@sbalghari sbalghari restored the fixes branch May 31, 2026 20:10
@coderabbitai coderabbitai Bot mentioned this pull request May 31, 2026
@sbalghari sbalghari deleted the fixes branch May 31, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant