Skip to content

fixes#25

Merged
sbalghari merged 1 commit into
mainfrom
fixes
May 31, 2026
Merged

fixes#25
sbalghari merged 1 commit into
mainfrom
fixes

Conversation

@sbalghari

@sbalghari sbalghari commented May 31, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Chores
    • Changed systemd service installation to exclusively use user-level services instead of system-level
    • Updated daemon service configurations for Actions and Clipboard Listener modules
    • Removed obsolete example service unit
    • Refined service discovery mechanism for post-installation setup

@coderabbitai

coderabbitai Bot commented May 31, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The PR consolidates systemd service handling to user-level units. Service module invocations are renamed, the Arch package script now installs all services to the user directory, and post-install logic is refactored to discover services via a unified path-parameterized helper instead of separate user and system checks.

Changes

User Systemd Units Consolidation

Layer / File(s) Summary
Service unit module updates
services/sbdots-actions.service, services/sbdots-clipboard-listener.service
Service unit files update ExecStart to invoke sbdots.daemons.actions and sbdots.daemons.cliplistener modules instead of the prior _d suffixed versions.
Arch packaging systemd installation
packaging/archlinux/PKGBUILD
PKGBUILD refactors package() to install all services/*.service files directly into /usr/lib/systemd/user/, removing the prior separate installation of user units from services/user/ and system units from services/system/.
Post-install service discovery refactor
src/sbdots/lifecycle/postinstall/start_service.py
start_services is refactored to call a new path-parameterized _get_available_services(path: Path) helper with /usr/lib/systemd/user/, removing the prior system-services availability check and root-privilege logging block.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • sbalghari/sbdots#22: Implements the same PKGBUILD systemd-install changes, _get_available_services(path) refactor, and ExecStart module name updates.
  • sbalghari/sbdots#20: Prior PR that added system and user unit installation to PKGBUILD and post-install logic; this PR refactors toward user-only consolidation.

Poem

🐰 From system and user, a choice clear and neat,
Now user units only, the refactor complete!
Module names shortened, paths unified so bright,
Systemd discovers with parameterized light. ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fixes' is too vague and generic, providing no meaningful information about what specifically is being fixed in this changeset. Replace with a specific title that describes the actual changes, such as 'Refactor systemd service configuration and user service discovery' or 'Update service modules and consolidate user service installation'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sbalghari sbalghari marked this pull request as draft May 31, 2026 20:19
@sbalghari sbalghari closed this May 31, 2026
@sbalghari sbalghari reopened this May 31, 2026
@sbalghari sbalghari marked this pull request as ready for review May 31, 2026 20:20
@sbalghari sbalghari merged commit 11bc109 into main May 31, 2026
2 of 3 checks passed
@sbalghari sbalghari deleted the fixes branch May 31, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant