Repository navigation
feat(hosted): run hosted upload from the app config (#140) - #304
Merged
Merged
Conversation
Contributor
|
/mira pause |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
rowkav09
force-pushed
the
feat/hosted-app-wiring
branch
from
September 23, 2026 22:59
ebff489 to
182af20
Compare
rowkav09
force-pushed
the
feat/hosted-app-wiring
branch
from
September 23, 2026 23:02
182af20 to
13c2606
Compare
4 tasks done
This was referenced Sep 23, 2026
10 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Last app-side slice of the #140 desktop uploader: the running app can now push to the hosted card service.
config.jsongets an optionalhosted: { enabled, url? }. Off by default, and absent from configs that don't set it, so existing installs are unchanged.urlmust be HTTPS (defaults to https://nowplaying-hosted.vercel.app). Unknown keys make the config invalid, same as the rest of the file.startHostedFromConfigstarts the loop from feat(hosted): credential store and polling loop for hosted uploads (#140) #297 with the uploader from feat(hosted): desktop uploader client for hosted cards (#140) #295. With no credential store it reportsno_credentialsinstead of starting.startAppFromConfigtakeshostedCredentials; the Windows entry passes the Credential Manager store. It returnshostedstatus andhostedCardUrl(), and stops the loop on close.hosted: { enabled, state, lastSuccessAt, error }(allow-listed words only, no tokens or IDs).The settings toggle and card link UI are tracked in #290 (web UI lane).
Checks
Issue
Part of #140