Skip to content

chore: Retire kagenti->rossoctl clone remap - #60

Open
rubambiza wants to merge 1 commit into
rossoctl:mainfrom
rubambiza:fix/retire-remap-shim-37
Open

chore: Retire kagenti->rossoctl clone remap#60
rubambiza wants to merge 1 commit into
rossoctl:mainfrom
rubambiza:fix/retire-remap-shim-37

Conversation

@rubambiza

Copy link
Copy Markdown
Contributor

Summary

Retires the transitional kagenti->rossoctl clone-dir remap now that the
stale-named clones have been removed from the scanner host.

Background

The link-health scanner iterates local clones by globbing $REPOS_DIR/*/,
which expands alphabetically. A stale kagenti clone (a copy of
rossoctl/rossoctl, weeks out of date) sorted ahead of the fresh rossoctl
clone. Both canonicalize to rossoctl via PROFILE_REMAP, and the
order-dependent dedup kept the first one it saw — the stale copy. The scanner
therefore read outdated files and re-filed broken-link issues that had already
been fixed on main.

The stale duplicate clones have since been removed from the host, so each core
repo now has a single, canonically named clone.

Change

  • Empty PROFILE_REMAP in config/org.env (data-only). With no mis-named
    clone dirs remaining, canonical_repo_for_dir() falls through to identity.
  • Refresh the org.sh comments to describe the generic, data-driven mechanism
    rather than asserting an active kagenti bridge.

canonical_repo_for_dir() and its data-driven design are intentionally kept so
a future org whose clone dirs are mis-named can re-enable the remap via
PROFILE_REMAP. No control-flow change; the allowlist filter and duplicate
dedup are untouched.

Testing

  • tests/test-core-repos.sh, tests/test-org-profile.sh,
    tests/test-lib-modules.sh, tests/test-lib-inventory.sh — pass.
  • Loading the shipped config/org.env confirms REMAP is empty and
    canonical_repo_for_dir returns identity for kagenti, rossoctl, cortex.

Fixes #37

Assisted-By: Claude Code

The transitional PROFILE_REMAP bridged pre-rename clone-dir basenames
(kagenti, kagenti-extensions) to their canonical repo names while
stale-named clones still lived on the scanner host. Those duplicate
clones have been removed, so each core repo now has a single,
canonically named clone.

Empty PROFILE_REMAP so canonical_repo_for_dir() resolves to identity,
and refresh the org.sh comments to describe the generic mechanism
without asserting an active kagenti bridge. The function and its
data-driven design are kept so a future org whose clone dirs are
mis-named can re-enable the remap via PROFILE_REMAP.

No logic change; existing tests pass unchanged (empty-REMAP identity
is already covered).

Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com>

Signed-off-by: Gloire Rubambiza <gloire@ibm.com>

@clawgenti clawgenti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward doc-and-data retirement — empties PROFILE_REMAP and refreshes comments to describe the generic mechanism without the now-gone kagenti bridge. All checks pass. Ready for human review.


Reviewed by clawgenti using the github-pr-review skill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-ai-review Request automated AI code review from clawgenti

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Rename clone dirs to canonical names and retire the remap shim

2 participants