Skip to content

Is the order of the args in lstsq in the APS agent's regress meta function correct?  #30

Description

@raymondchua

I am curious why in the regress_meta function in the APS agent, the reward is the first argument and not rep? According to the torch documentation, the lstsq function tries to find X in the the equation ||AX -B||_F, with A being the first argument and B being the second argument of the function. Since the equation that we are trying to solve is finding w, such that ||rep * w - reward||, shouldn't A be rep instead?

task = torch.linalg.lstsq(reward, rep)[0][:rep.size(1), :][0]

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions