Skip to content

fix: reject non-integer --limit values in list commands #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RaphaelFakhri wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reject non-integer --limit values in list commands #424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/pagination.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { maskKey } from './config';
import { outputError } from './output';

export function parseLimitOpt(raw: string, globalOpts: GlobalOpts): number {
const limit = parseInt(raw, 10);
if (Number.isNaN(limit) || limit < 1 || limit > 100) {
const limit = Number(raw);
if (!Number.isInteger(limit) || limit < 1 || limit > 100) {
outputError(
{
message: '--limit must be an integer between 1 and 100',
Expand Down
40 changes: 40 additions & 0 deletions tests/lib/pagination.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
import type { GlobalOpts } from '../../src/lib/client';
import {
buildPaginationOpts,
parseLimitOpt,
printPaginationHint,
} from '../../src/lib/pagination';
import { captureTestEnv, mockExitThrow, setNonInteractive } from '../helpers';
Expand Down Expand Up @@ -67,6 +68,45 @@ describe('buildPaginationOpts', () => {
});
});

describe('parseLimitOpt', () => {
const restoreEnv = captureTestEnv();
let exitSpy: MockInstance | undefined;
let logSpy: MockInstance | undefined;

afterEach(() => {
restoreEnv();
exitSpy?.mockRestore();
logSpy?.mockRestore();
exitSpy = undefined;
logSpy = undefined;
});

const globalOpts = {} as GlobalOpts;

it.each(['1', '10', '100'])('accepts %s', (raw) => {
expect(parseLimitOpt(raw, globalOpts)).toBe(Number(raw));
});

it.each([
'0',
'101',
'',
'abc',
'2.5',
'25abc',
'1,000',
])('errors with invalid_limit for %j', (raw) => {
setNonInteractive();
logSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
exitSpy = mockExitThrow();

expect(() => parseLimitOpt(raw, globalOpts)).toThrow();

const output = logSpy.mock.calls.map((call) => call[0]).join(' ');
expect(output).toContain('invalid_limit');
});
});

describe('printPaginationHint', () => {
let logSpy: MockInstance;

Expand Down