Repository navigation
fix: reject non-integer --limit values in list commands - #424
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseLimitOptreads--limitwithparseInt, which keeps the leading digits and drops the rest. Every list command uses it, so a value that is not an integer between 1 and 100 is sent as a different number, with exit code 0, even though the error message says--limit must be an integer between 1 and 100.limiton main2.5225abc251,0001Repro against a local mock of the API:
On main the mock receives
GET /emails?limit=2and the command exits 0. With this change the command returnsinvalid_limit, exits 1 and sends nothing.--limit 25still sendslimit=25.Change
parseLimitOptparses the whole string withNumberand requiresNumber.isInteger, keeping the existing 1-100 range check, error message and error code. Empty input is still rejected (Number('')is0).Tests
Added
parseLimitOptcases totests/lib/pagination.test.ts:1,10and100are accepted, and0,101,'',abc,2.5,25abcand1,000returninvalid_limit. The2.5,25abcand1,000cases fail on main and pass with this change.Ran
pnpm test(1478 passed, 1 skipped),pnpm lintandpnpm typecheck.Fixes #423