Add feature handle-panics - #525
Merged
Merged
Conversation
rexmas
reviewed
Dec 8, 2024
| return; | ||
| } | ||
|
|
||
| if let Some(hook) = unsafe { DEFAULT_HOOK.as_ref() } { |
Member
There was a problem hiding this comment.
I think we might want to add #[allow(static_mut_refs)] right above this to eliminate that warning.
Contributor
Author
There was a problem hiding this comment.
I think it's worth more to run full fmt+clippy check as a separate PR. There are too many warnings besides this one.
rexmas
approved these changes
Dec 8, 2024
rexmas
left a comment
rexmas
left a comment
Member
There was a problem hiding this comment.
looks good, i'm in favor of having a feature flag for this for now since some people may rely on the output of panics still and not want them suppressed. when we ship the other pr in i may be in favor of removing the ff since we'll need a major version bump
matthew-russo
approved these changes
Dec 9, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
handle-panicsis enabled, panic backtrace which happens in test case is silenced instead of spitting it to consoleThis PR is part of #421/#517 which doesn't change public API. Part with backtraces capture will be presented as separate PR
P.S: Do we actually need feature to gate this out? Or should it be just enabled by
std?